| Message ID | 20220616080210.18531-1-mgurtovoy@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] scsi: iscsi: Make iscsi_unregister_transport() return void | expand |
Max, > This function always returns 0. We can make it return void to simplify > the code. Also, no caller ever checks the return value of this function. Applied to 5.20/scsi-staging, thanks!
On Thu, 16 Jun 2022 11:02:10 +0300, Max Gurtovoy wrote: > This function always returns 0. We can make it return void to simplify > the code. Also, no caller ever checks the return value of this function. > > Applied to 5.20/scsi-queue, thanks! [1/1] scsi: iscsi: Make iscsi_unregister_transport() return void https://git.kernel.org/mkp/scsi/c/6a33ed506416
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 2c0dd64159b0..5601633837cc 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -4807,7 +4807,7 @@ iscsi_register_transport(struct iscsi_transport *tt) } EXPORT_SYMBOL_GPL(iscsi_register_transport); -int iscsi_unregister_transport(struct iscsi_transport *tt) +void iscsi_unregister_transport(struct iscsi_transport *tt) { struct iscsi_internal *priv; unsigned long flags; @@ -4830,8 +4830,6 @@ int iscsi_unregister_transport(struct iscsi_transport *tt) sysfs_remove_group(&priv->dev.kobj, &iscsi_transport_group); device_unregister(&priv->dev); mutex_unlock(&rx_queue_mutex); - - return 0; } EXPORT_SYMBOL_GPL(iscsi_unregister_transport); diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h index 9acb8422f680..695396a5f607 100644 --- a/include/scsi/scsi_transport_iscsi.h +++ b/include/scsi/scsi_transport_iscsi.h @@ -162,7 +162,7 @@ struct iscsi_transport { * transport registration upcalls */ extern struct scsi_transport_template *iscsi_register_transport(struct iscsi_transport *tt); -extern int iscsi_unregister_transport(struct iscsi_transport *tt); +extern void iscsi_unregister_transport(struct iscsi_transport *tt); /* * control plane upcalls
This function always returns 0. We can make it return void to simplify the code. Also, no caller ever checks the return value of this function. Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> --- drivers/scsi/scsi_transport_iscsi.c | 4 +--- include/scsi/scsi_transport_iscsi.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-)