| Message ID | 20220617232434.1139950-3-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Commit | ff46c2c481f2a379c457f2a815afdd6819521cc0 |
| Headers | show |
| Series | [v2,1/3] drm/msm/dp: remove unused stubs | expand |
On 6/24/2022 10:37 AM, Abhinav Kumar wrote: > > > > -------- Forwarded Message -------- > Subject: [PATCH v2 3/3] drm/msm/dp: remove dp_display_en/disable > prototypes and data argument > Date: Sat, 18 Jun 2022 02:24:34 +0300 > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, > Abhinav Kumar <quic_abhinavk@quicinc.com> > CC: Stephen Boyd <swboyd@chromium.org>, David Airlie > <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Bjorn Andersson > <bjorn.andersson@linaro.org>, linux-arm-msm@vger.kernel.org, > dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org > > Remove unused dp_display_en/disable prototypes. While we are at it, > remove extra 'data' argument that is unused. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > Changes since v1: > - Rebased and dropped the dp_display_enable() chunk > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 96defacc92dc..c17a799d3009 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -608,9 +608,6 @@ static int dp_hpd_plug_handle(struct > dp_display_private *dp, u32 data) > return 0; > }; > -static int dp_display_enable(struct dp_display_private *dp, bool > force_link_train); > -static int dp_display_disable(struct dp_display_private *dp, u32 data); > - > static void dp_display_handle_plugged_change(struct msm_dp *dp_display, > bool plugged) > { > @@ -894,7 +891,7 @@ static int dp_display_post_enable(struct msm_dp > *dp_display) > return 0; > } > -static int dp_display_disable(struct dp_display_private *dp, u32 data) > +static int dp_display_disable(struct dp_display_private *dp) > { > struct msm_dp *dp_display = &dp->dp_display; > @@ -1676,7 +1673,7 @@ void dp_bridge_enable(struct drm_bridge > *drm_bridge) > rc = dp_display_post_enable(dp); > if (rc) { > DRM_ERROR("DP display post enable failed, rc=%d\n", rc); > - dp_display_disable(dp_display, 0); > + dp_display_disable(dp_display); > } > /* completed connection */ > @@ -1717,7 +1714,7 @@ void dp_bridge_post_disable(struct drm_bridge > *drm_bridge) > return; > } > - dp_display_disable(dp_display, 0); > + dp_display_disable(dp_display); > state = dp_display->hpd_state; > if (state == ST_DISCONNECT_PENDING) {
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 96defacc92dc..c17a799d3009 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -608,9 +608,6 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data) return 0; }; -static int dp_display_enable(struct dp_display_private *dp, bool force_link_train); -static int dp_display_disable(struct dp_display_private *dp, u32 data); - static void dp_display_handle_plugged_change(struct msm_dp *dp_display, bool plugged) { @@ -894,7 +891,7 @@ static int dp_display_post_enable(struct msm_dp *dp_display) return 0; } -static int dp_display_disable(struct dp_display_private *dp, u32 data) +static int dp_display_disable(struct dp_display_private *dp) { struct msm_dp *dp_display = &dp->dp_display; @@ -1676,7 +1673,7 @@ void dp_bridge_enable(struct drm_bridge *drm_bridge) rc = dp_display_post_enable(dp); if (rc) { DRM_ERROR("DP display post enable failed, rc=%d\n", rc); - dp_display_disable(dp_display, 0); + dp_display_disable(dp_display); } /* completed connection */ @@ -1717,7 +1714,7 @@ void dp_bridge_post_disable(struct drm_bridge *drm_bridge) return; } - dp_display_disable(dp_display, 0); + dp_display_disable(dp_display); state = dp_display->hpd_state; if (state == ST_DISCONNECT_PENDING) {
Remove unused dp_display_en/disable prototypes. While we are at it, remove extra 'data' argument that is unused. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes since v1: - Rebased and dropped the dp_display_enable() chunk --- drivers/gpu/drm/msm/dp/dp_display.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)