| Message ID | 20220617144714.817765-3-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: qcom: gcc-msm8916: modernize the driver | expand |
On 18/06/2022 06:35, Dmitry Baryshkov wrote: > On 18/06/2022 04:40, Krzysztof Kozlowski wrote: >> On 17/06/2022 07:47, Dmitry Baryshkov wrote: >>> Separate bindings for GCC on Qualcomm MSM8916 platforms. This adds new >>> clocks/clock-names properties to be used for clock links. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> .../bindings/clock/qcom,gcc-msm8916.yaml | 61 +++++++++++++++++++ >>> .../bindings/clock/qcom,gcc-other.yaml | 1 - >>> 2 files changed, 61 insertions(+), 1 deletion(-) >>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml >>> new file mode 100644 >>> index 000000000000..564aa764b17b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml >>> @@ -0,0 +1,61 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8916.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Global Clock & Reset Controller Binding for MSM8916 >>> + >>> +maintainers: >>> + - Stephen Boyd <sboyd@kernel.org> >>> + - Taniya Das <quic_tdas@quicinc.com> >>> + >>> +description: | >>> + Qualcomm global clock control module which supports the clocks, resets and >>> + power domains on MSM8916. >>> + >>> + See also: >>> + - dt-bindings/clock/qcom,gcc-msm8916.h >>> + >>> +properties: >>> + compatible: >>> + const: qcom,gcc-msm8916 >>> + >>> + clocks: >>> + items: >>> + - description: XO source >>> + - description: Sleep clock source >>> + - description: DSI phy instance 0 dsi clock >>> + - description: DSI phy instance 0 byte clock >>> + - description: External MCLK clock >>> + - description: External Primary I2S clock >>> + - description: External Secondary I2S clock >>> + >>> + clock-names: >>> + items: >>> + - const: xo >>> + - const: sleep_clk >> >> Just "sleep" > > I was hesitating here as all other gcc drivers use 'sleep_clk'. Eh, indeed, these are existing bindings and drivers. Let's keep sleep_clk. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml new file mode 100644 index 000000000000..564aa764b17b --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8916.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Global Clock & Reset Controller Binding for MSM8916 + +maintainers: + - Stephen Boyd <sboyd@kernel.org> + - Taniya Das <quic_tdas@quicinc.com> + +description: | + Qualcomm global clock control module which supports the clocks, resets and + power domains on MSM8916. + + See also: + - dt-bindings/clock/qcom,gcc-msm8916.h + +properties: + compatible: + const: qcom,gcc-msm8916 + + clocks: + items: + - description: XO source + - description: Sleep clock source + - description: DSI phy instance 0 dsi clock + - description: DSI phy instance 0 byte clock + - description: External MCLK clock + - description: External Primary I2S clock + - description: External Secondary I2S clock + + clock-names: + items: + - const: xo + - const: sleep_clk + - const: dsi0pll + - const: dsi0pllbyte + - const: ext_mclk + - const: ext_pri_i2s + - const: ext_sec_i2s + +required: + - compatible + +allOf: + - $ref: qcom,gcc.yaml# + +unevaluatedProperties: false + +examples: + - | + clock-controller@300000 { + compatible = "qcom,gcc-msm8916"; + #clock-cells = <1>; + #reset-cells = <1>; + #power-domain-cells = <1>; + reg = <0x300000 0x90000>; + }; +... diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml index 6c45e0f85494..d3e591495b41 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml @@ -41,7 +41,6 @@ properties: - qcom,gcc-mdm9607 - qcom,gcc-msm8226 - qcom,gcc-msm8660 - - qcom,gcc-msm8916 - qcom,gcc-msm8939 - qcom,gcc-msm8953 - qcom,gcc-msm8960
Separate bindings for GCC on Qualcomm MSM8916 platforms. This adds new clocks/clock-names properties to be used for clock links. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../bindings/clock/qcom,gcc-msm8916.yaml | 61 +++++++++++++++++++ .../bindings/clock/qcom,gcc-other.yaml | 1 - 2 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml