diff mbox series

input/serio: Fix refcount leak bug in i8042-sparcio

Message ID 20220619073036.4067872-1-windhl@126.com
State New
Headers show
Series input/serio: Fix refcount leak bug in i8042-sparcio | expand

Commit Message

Liang He June 19, 2022, 7:30 a.m. UTC 
In i8042_platform_init() and i8042_platform_exit(), we need call
of_node_put() to keep refcount balance.

Signed-off-by: Liang He <windhl@126.com>
---
 drivers/input/serio/i8042-sparcio.h | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h
index fce76812843b..a2a9db9220d7 100644
--- a/drivers/input/serio/i8042-sparcio.h
+++ b/drivers/input/serio/i8042-sparcio.h
@@ -108,6 +108,8 @@  static int __init i8042_platform_init(void)
 	struct device_node *root = of_find_node_by_path("/");
 	const char *name = of_get_property(root, "name", NULL);
 
+	of_node_put(root);
+
 	if (name && !strcmp(name, "SUNW,JavaStation-1")) {
 		/* Hardcoded values for MrCoffee.  */
 		i8042_kbd_irq = i8042_aux_irq = 13 | 0x20;
@@ -139,6 +141,8 @@  static inline void i8042_platform_exit(void)
 	struct device_node *root = of_find_node_by_path("/");
 	const char *name = of_get_property(root, "name", NULL);
 
+	of_node_put(root);
+
 	if (!name || strcmp(name, "SUNW,JavaStation-1"))
 		platform_driver_unregister(&sparc_i8042_driver);
 }