| Message ID | 20220619151225.209029-8-tmaimon77@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce Nuvoton Arbel NPCM8XX BMC SoC | expand |
On 19/06/2022 17:12, Tomer Maimon wrote: > Describe syscon property that handles general control registers (GCR) in > Nuvoton BMC NPCM reset driver. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > .../devicetree/bindings/reset/nuvoton,npcm750-reset.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml > index fa5e4ea6400e..7ba3a6ff82ed 100644 > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml > @@ -19,6 +19,9 @@ properties: > '#reset-cells': > const: 2 > > + nuvoton,sysgcr: > + description: a phandle to access GCR registers. That's not valid. You miss here ref. My comment was to skip quotes and you removed entire ref. Best regards, Krzysztof
Hi Krzysztof, On Mon, 20 Jun 2022 at 11:22, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 19/06/2022 17:12, Tomer Maimon wrote: > > Describe syscon property that handles general control registers (GCR) in > > Nuvoton BMC NPCM reset driver. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../devicetree/bindings/reset/nuvoton,npcm750-reset.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml > > index fa5e4ea6400e..7ba3a6ff82ed 100644 > > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml > > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml > > @@ -19,6 +19,9 @@ properties: > > '#reset-cells': > > const: 2 > > > > + nuvoton,sysgcr: > > + description: a phandle to access GCR registers. > > That's not valid. You miss here ref. My comment was to skip quotes and > you removed entire ref. Will add the ref next version. > > Best regards, > Krzysztof Best regards, Tomer
diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml index fa5e4ea6400e..7ba3a6ff82ed 100644 --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml @@ -19,6 +19,9 @@ properties: '#reset-cells': const: 2 + nuvoton,sysgcr: + description: a phandle to access GCR registers. + nuvoton,sw-reset-number: $ref: /schemas/types.yaml#/definitions/uint32 minimum: 1 @@ -31,6 +34,7 @@ required: - compatible - reg - '#reset-cells' + - nuvoton,sysgcr additionalProperties: false @@ -41,6 +45,7 @@ examples: compatible = "nuvoton,npcm750-reset"; reg = <0xf0801000 0x70>; #reset-cells = <2>; + nuvoton,sysgcr = <&gcr>; nuvoton,sw-reset-number = <2>; };
Describe syscon property that handles general control registers (GCR) in Nuvoton BMC NPCM reset driver. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- .../devicetree/bindings/reset/nuvoton,npcm750-reset.yaml | 5 +++++ 1 file changed, 5 insertions(+)