| Message ID | 20220620200644.1961936-19-aidanmacdonald.0x0@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | regmap-irq cleanups and refactoring | expand |
On Mon, Jun 20, 2022 at 10:08 PM Aidan MacDonald <aidanmacdonald.0x0@gmail.com> wrote: > > The qcom-pm8008 appears to use "1 to enable" convention for > enabling interrupts, with separate set and clear registers. > It's relying on masks and unmasks being inverted from their It relies > intuitive meaning, so it needs the broken_mask_unmask flag. How has it worked until now?
On Tue, Jun 21, 2022 at 11:35:09AM +0200, Andy Shevchenko wrote: > On Mon, Jun 20, 2022 at 10:08 PM Aidan MacDonald > <aidanmacdonald.0x0@gmail.com> wrote: > > > > The qcom-pm8008 appears to use "1 to enable" convention for > > enabling interrupts, with separate set and clear registers. > > It's relying on masks and unmasks being inverted from their > > It relies > > > intuitive meaning, so it needs the broken_mask_unmask flag. > > How has it worked until now? It is as Aidan rightly pointed out. When I was writing the pm8008 driver, I found that the mask and unmask terminology used in the framework was inverted when it came to the hardware, so I had to make do and swap them. It works because in regmap_irq_sync_unlock(), the same mask is used to update mask_reg and unmask_reg, except that it is inverted for updating the unmask register. So, by just swapping which register gets updated with the plain mask and which one gets updated with the inverted mask, I could use the framework to accomplish the setting and clearing of the correct registers.
diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c index da16566f7883..18095e72714e 100644 --- a/drivers/mfd/qcom-pm8008.c +++ b/drivers/mfd/qcom-pm8008.c @@ -141,6 +141,7 @@ static struct regmap_irq_chip pm8008_irq_chip = { .status_base = PM8008_STATUS_BASE, .mask_base = PM8008_MASK_BASE, .unmask_base = PM8008_UNMASK_BASE, + .broken_mask_unmask = true, .ack_base = PM8008_ACK_BASE, .config_base = pm8008_config_regs, .num_config_bases = ARRAY_SIZE(pm8008_config_regs),
The qcom-pm8008 appears to use "1 to enable" convention for enabling interrupts, with separate set and clear registers. It's relying on masks and unmasks being inverted from their intuitive meaning, so it needs the broken_mask_unmask flag. Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com> --- drivers/mfd/qcom-pm8008.c | 1 + 1 file changed, 1 insertion(+)