| Message ID | 20220623115631.22209-4-peterwu.pub@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Mediatek MT6370 PMIC support | expand |
On 23/06/2022 13:56, ChiaEn Wu wrote: > From: ChiYuan Huang <cy_huang@richtek.com> > > Add Mediatek mt6370 current sink type LED indicator binding documentation. > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > --- > > v3 > - Use leds-class-multicolor.yaml instead of common.yaml. > - Split multi-led and led node. > - Add subdevice "led" in "multi-led". > --- > .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > > diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > new file mode 100644 > index 0000000..45030f3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6370 PMIC from MediaTek Integrated. > + > +maintainers: > + - Alice Chen <alice_chen@richtek.com> > + > +description: | > + This module is part of the MT6370 MFD device. > + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode > + > +allOf: > + - $ref: leds-class-multicolor.yaml# > + > +properties: > + compatible: > + const: mediatek,mt6370-indicator > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-3]$": > + type: object Here as well unevaluatedProperties:false (on the type level) > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^led@[0-2]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + required: > + - reg > + - color > + > + required: > + - reg > + - color > + - "#address-cells" > + - "#size-cells" > + > + "^led@[0-3]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + required: > + - reg > + - color > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false Best regards, Krzysztof
On 24/06/2022 12:35, Krzysztof Kozlowski wrote: > On 23/06/2022 13:56, ChiaEn Wu wrote: >> From: ChiYuan Huang <cy_huang@richtek.com> >> >> Add Mediatek mt6370 current sink type LED indicator binding documentation. >> >> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> >> --- >> >> v3 >> - Use leds-class-multicolor.yaml instead of common.yaml. >> - Split multi-led and led node. >> - Add subdevice "led" in "multi-led". >> --- >> .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >> >> diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >> new file mode 100644 >> index 0000000..45030f3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >> @@ -0,0 +1,77 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: LED driver for MT6370 PMIC from MediaTek Integrated. >> + >> +maintainers: >> + - Alice Chen <alice_chen@richtek.com> >> + >> +description: | >> + This module is part of the MT6370 MFD device. >> + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode >> + >> +allOf: >> + - $ref: leds-class-multicolor.yaml# >> + >> +properties: >> + compatible: >> + const: mediatek,mt6370-indicator >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> +patternProperties: >> + "^multi-led@[0-3]$": >> + type: object > > Here as well unevaluatedProperties:false (on the type level) Ah, no, it does not work currently. Your code looks good. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file mode 100644 index 0000000..45030f3 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6370 PMIC from MediaTek Integrated. + +maintainers: + - Alice Chen <alice_chen@richtek.com> + +description: | + This module is part of the MT6370 MFD device. + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode + +allOf: + - $ref: leds-class-multicolor.yaml# + +properties: + compatible: + const: mediatek,mt6370-indicator + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^multi-led@[0-3]$": + type: object + + properties: + reg: + enum: [0, 1, 2, 3] + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + patternProperties: + "^led@[0-2]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + required: + - reg + - color + + required: + - reg + - color + - "#address-cells" + - "#size-cells" + + "^led@[0-3]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + enum: [0, 1, 2, 3] + + required: + - reg + - color + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false