diff mbox series

dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example

Message ID 20220627143340.477120-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example | expand

Commit Message

Krzysztof Kozlowski June 27, 2022, 2:33 p.m. UTC
In the example, alone compatible "qcom,qcs404" is not correct.  Add
proper board compatibles for QCS404 Evaluation Board.

Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Can be picked up independently, although the issue reported by Rob was
caused by:
https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
---
 .../devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Viresh Kumar June 28, 2022, 12:45 a.m. UTC | #1
On 27-06-22, 13:50, Rob Herring wrote:
> On Mon, Jun 27, 2022 at 04:33:40PM +0200, Krzysztof Kozlowski wrote:
> > In the example, alone compatible "qcom,qcs404" is not correct.  Add
> > proper board compatibles for QCS404 Evaluation Board.
> > 
> > Reported-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > ---
> > 
> > Can be picked up independently, although the issue reported by Rob was
> > caused by:
> > https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
> 
> Best to go in that tree unless it's going to take weeks...

Lemme know Krzysztof about the timing, I am going to send a pull
request for cpufreq fixes very soon, so I can take it as well if you
want.

> > ---
> >  .../devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml       | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski June 28, 2022, 7:52 a.m. UTC | #2
On 28/06/2022 02:45, Viresh Kumar wrote:
> On 27-06-22, 13:50, Rob Herring wrote:
>> On Mon, Jun 27, 2022 at 04:33:40PM +0200, Krzysztof Kozlowski wrote:
>>> In the example, alone compatible "qcom,qcs404" is not correct.  Add
>>> proper board compatibles for QCS404 Evaluation Board.
>>>
>>> Reported-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> ---
>>>
>>> Can be picked up independently, although the issue reported by Rob was
>>> caused by:
>>> https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
>>
>> Best to go in that tree unless it's going to take weeks...
> 
> Lemme know Krzysztof about the timing, I am going to send a pull
> request for cpufreq fixes very soon, so I can take it as well if you
> want.


Thanks Viresh, but I think Rob has a point here - this should be rather
same tree, otherwise checks on your tree complain about undocumented
board compatibles from this patch (because they are in this original tree).

I'll take it and add to my pull request for Rob or Bjorn.

Best regards,
Krzysztof
Viresh Kumar June 28, 2022, 7:54 a.m. UTC | #3
On 27-06-22, 16:33, Krzysztof Kozlowski wrote:
> In the example, alone compatible "qcom,qcs404" is not correct.  Add
> proper board compatibles for QCS404 Evaluation Board.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Can be picked up independently, although the issue reported by Rob was
> caused by:
> https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
> ---
>  .../devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> index a9a776da5505..10b3a7a4af36 100644
> --- a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> @@ -63,8 +63,8 @@ additionalProperties: true
>  examples:
>    - |
>      / {
> -        model = "Qualcomm Technologies, Inc. QCS404";
> -        compatible = "qcom,qcs404";
> +        model = "Qualcomm Technologies, Inc. QCS404 EVB 1000";
> +        compatible = "qcom,qcs404-evb-1000", "qcom,qcs404-evb", "qcom,qcs404";
>          #address-cells = <2>;
>          #size-cells = <2>;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Krzysztof Kozlowski June 28, 2022, 9:09 a.m. UTC | #4
On Mon, 27 Jun 2022 16:33:40 +0200, Krzysztof Kozlowski wrote:
> In the example, alone compatible "qcom,qcs404" is not correct.  Add
> proper board compatibles for QCS404 Evaluation Board.
> 
> 

Applied, thanks!

[1/1] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
      https://git.kernel.org/krzk/linux-dt/c/062529700fdb843eee921961eb3cbc6a51419491

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
index a9a776da5505..10b3a7a4af36 100644
--- a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
@@ -63,8 +63,8 @@  additionalProperties: true
 examples:
   - |
     / {
-        model = "Qualcomm Technologies, Inc. QCS404";
-        compatible = "qcom,qcs404";
+        model = "Qualcomm Technologies, Inc. QCS404 EVB 1000";
+        compatible = "qcom,qcs404-evb-1000", "qcom,qcs404-evb", "qcom,qcs404";
         #address-cells = <2>;
         #size-cells = <2>;