diff mbox series

scsi: fcoe: remove redundant assignment to variable wlen

Message ID 20220623164710.76831-1-colin.i.king@gmail.com
State New
Headers show
Series scsi: fcoe: remove redundant assignment to variable wlen | expand

Commit Message

Colin Ian King June 23, 2022, 4:47 p.m. UTC
Variable wlen is being assigned a value that is never read, it is
being re-assigned with a different value later on. The assignment
is redundant and can be removed.

Cleans up clang scan build warning:
drivers/scsi/fcoe/fcoe.c:1491:2: warning: Value stored to 'wlen'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/scsi/fcoe/fcoe.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin K. Petersen June 28, 2022, 2:45 a.m. UTC | #1
Colin,

> Variable wlen is being assigned a value that is never read, it is
> being re-assigned with a different value later on. The assignment is
> redundant and can be removed.

Applied to 5.20/scsi-staging, thanks!
Martin K. Petersen July 7, 2022, 9:47 p.m. UTC | #2
On Thu, 23 Jun 2022 17:47:10 +0100, Colin Ian King wrote:

> Variable wlen is being assigned a value that is never read, it is
> being re-assigned with a different value later on. The assignment
> is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/scsi/fcoe/fcoe.c:1491:2: warning: Value stored to 'wlen'
> is never read [deadcode.DeadStores]
> 
> [...]

Applied to 5.20/scsi-queue, thanks!

[1/1] scsi: fcoe: remove redundant assignment to variable wlen
      https://git.kernel.org/mkp/scsi/c/07f0c8aff551
diff mbox series

Patch

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index c2a59109857a..6ec296321ffc 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1488,7 +1488,6 @@  static int fcoe_xmit(struct fc_lport *lport, struct fc_frame *fp)
 
 	fh = fc_frame_header_get(fp);
 	skb = fp_skb(fp);
-	wlen = skb->len / FCOE_WORD_TO_BYTE;
 
 	if (!lport->link_up) {
 		kfree_skb(skb);