| Message ID | 20220630195541.4368-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] i2c: scmi: Replace open coded acpi_match_device() | expand |
> Discard this, a last minute change that makes it not buildable.
Do you plan to send an update?
On Wed, Jul 06, 2022 at 09:32:05PM +0200, Wolfram Sang wrote: > > > Discard this, a last minute change that makes it not buildable. > > Do you plan to send an update? Just did it.
diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c index 6746aa46d96c..ba20f6c60e06 100644 --- a/drivers/i2c/busses/i2c-scmi.c +++ b/drivers/i2c/busses/i2c-scmi.c @@ -376,10 +376,9 @@ static int acpi_smbus_cmi_add(struct acpi_device *device) smbus_cmi->cap_read = 0; smbus_cmi->cap_write = 0; - for (id = acpi_smbus_cmi_ids; id->id[0]; id++) - if (!strcmp(id->id, acpi_device_hid(device))) - smbus_cmi->methods = - (struct smbus_methods_t *) id->driver_data; + id = acpi_match_device(device, acpi_smbus_cmi_ids); + if (id) + smbus_cmi->methods = (struct smbus_methods_t *)id->driver_data; acpi_walk_namespace(ACPI_TYPE_METHOD, smbus_cmi->handle, 1, acpi_smbus_cmi_query_methods, NULL, smbus_cmi, NULL);
Replace open coded acpi_match_device() in acpi_smbus_cmi_add(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/i2c-scmi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)