diff mbox series

[v3,3/3] arm64: dts: qcom: msm8996: add #clock-cells and XO clock to the HDMI PHY node

Message ID 20220704161148.814510-4-dmitry.baryshkov@linaro.org
State Accepted
Commit 157b615066288f84e1812964a439603cfe8c1a19
Headers show
Series drm/msm/hdmi: turn MSM8996 HDMI PHY into OF clock provider | expand

Commit Message

Dmitry Baryshkov July 4, 2022, 4:11 p.m. UTC
Add #clock-cells property to the HDMI PHY device node to let other nodes
resolve the hdmipll clock. While we are at it, also add the XO clock to
the device node.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Dmitry Baryshkov Aug. 26, 2022, 2:25 p.m. UTC | #1
On 04/07/2022 19:11, Dmitry Baryshkov wrote:
> Add #clock-cells property to the HDMI PHY device node to let other nodes
> resolve the hdmipll clock. While we are at it, also add the XO clock to
> the device node.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Bjorn, I'm picking the patches 1,2 into msm-next. Could you please pick 
this patch into your dts-for-6.1?

> ---
>   arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 25d6b26fab60..b72385ffecc6 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1049,9 +1049,13 @@ hdmi_phy: hdmi-phy@9a0600 {
>   					    "hdmi_phy";
>   
>   				clocks = <&mmcc MDSS_AHB_CLK>,
> -					 <&gcc GCC_HDMI_CLKREF_CLK>;
> +					 <&gcc GCC_HDMI_CLKREF_CLK>,
> +					 <&xo_board>;
>   				clock-names = "iface",
> -					      "ref";
> +					      "ref",
> +					      "xo";
> +
> +				#clock-cells = <0>;
>   
>   				status = "disabled";
>   			};
Dmitry Baryshkov Sept. 9, 2022, 10:18 a.m. UTC | #2
On 26/08/2022 17:25, Dmitry Baryshkov wrote:
> On 04/07/2022 19:11, Dmitry Baryshkov wrote:
>> Add #clock-cells property to the HDMI PHY device node to let other nodes
>> resolve the hdmipll clock. While we are at it, also add the XO clock to
>> the device node.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Bjorn, I'm picking the patches 1,2 into msm-next. Could you please pick 
> this patch into your dts-for-6.1?

Again, gracious ping.

> 
>> ---
>>   arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi 
>> b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index 25d6b26fab60..b72385ffecc6 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -1049,9 +1049,13 @@ hdmi_phy: hdmi-phy@9a0600 {
>>                           "hdmi_phy";
>>                   clocks = <&mmcc MDSS_AHB_CLK>,
>> -                     <&gcc GCC_HDMI_CLKREF_CLK>;
>> +                     <&gcc GCC_HDMI_CLKREF_CLK>,
>> +                     <&xo_board>;
>>                   clock-names = "iface",
>> -                          "ref";
>> +                          "ref",
>> +                          "xo";
>> +
>> +                #clock-cells = <0>;
>>                   status = "disabled";
>>               };
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 25d6b26fab60..b72385ffecc6 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1049,9 +1049,13 @@  hdmi_phy: hdmi-phy@9a0600 {
 					    "hdmi_phy";
 
 				clocks = <&mmcc MDSS_AHB_CLK>,
-					 <&gcc GCC_HDMI_CLKREF_CLK>;
+					 <&gcc GCC_HDMI_CLKREF_CLK>,
+					 <&xo_board>;
 				clock-names = "iface",
-					      "ref";
+					      "ref",
+					      "xo";
+
+				#clock-cells = <0>;
 
 				status = "disabled";
 			};