| Message ID | 20220703091132.1412063-11-peng.fan@oss.nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | interconnect: support i.MX8MP | expand |
Hi Georgi, > Subject: Re: [PATCH V3 10/10] arm64: dts: imx8mp: add NoC node > > > Hi Peng, > > On 3.07.22 12:11, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add i.MX8MP NoC node to make the interconnect i.MX8MP driver could > work. > > Currently dynamic frequency scaling of the i.MX8MP NoC has not been > > supported, only NoC initial settings are configured by interconnect > > driver. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 22 > ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > index eb2d516278eb..13a2ee77d3c6 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > @@ -4,6 +4,7 @@ > > */ > > > > #include <dt-bindings/clock/imx8mp-clock.h> > > +#include <dt-bindings/interconnect/fsl,imx8mp.h> > > It's also possible to drop this line for now and add it in the next patches > when we add the interconnect consumers. This will allow merging this DT > patch independently. But it's up to Shawn. > > > #include <dt-bindings/power/imx8mp-power.h> > > #include <dt-bindings/gpio/gpio.h> > > #include <dt-bindings/input/input.h> @@ -1019,6 +1020,27 @@ eqos: > > ethernet@30bf0000 { > > }; > > }; > > > > + noc: interconnect@32700000 { > > + compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc", > "syscon"; > > I got the impression that we are dropping the syscon, or not? I just checked the dt-bindings V1 mail. You are right, syscon should be dropped. > > > + reg = <0x32700000 0x100000>; > > + clocks = <&clk IMX8MP_CLK_NOC>; > > + #interconnect-cells = <1>; > > + > > + operating-points-v2 = <&noc_opp_table>; > > + > > + noc_opp_table: opp-table { > > + compatible = "operating-points-v2"; > > + > > + opp-200M { > > + opp-hz = /bits/ 64 <200000000>; > > + }; > > + > > + opp-1000M { > > + opp-hz = /bits/ 64 <1000000000>; > > + }; > > + }; > > + }; > > + > > aips4: bus@32c00000 { > > compatible = "fsl,aips-bus", "simple-bus"; > > reg = <0x32c00000 0x400000>; > Patches 1-9 look good and I am planning to merge them. Thanks, Then I only need to repost this single patch for a new version. Thanks, Peng. > > Thanks, > Georgi
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index eb2d516278eb..13a2ee77d3c6 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -4,6 +4,7 @@ */ #include <dt-bindings/clock/imx8mp-clock.h> +#include <dt-bindings/interconnect/fsl,imx8mp.h> #include <dt-bindings/power/imx8mp-power.h> #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> @@ -1019,6 +1020,27 @@ eqos: ethernet@30bf0000 { }; }; + noc: interconnect@32700000 { + compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc", "syscon"; + reg = <0x32700000 0x100000>; + clocks = <&clk IMX8MP_CLK_NOC>; + #interconnect-cells = <1>; + + operating-points-v2 = <&noc_opp_table>; + + noc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-200M { + opp-hz = /bits/ 64 <200000000>; + }; + + opp-1000M { + opp-hz = /bits/ 64 <1000000000>; + }; + }; + }; + aips4: bus@32c00000 { compatible = "fsl,aips-bus", "simple-bus"; reg = <0x32c00000 0x400000>;