| Message ID | 20220705202837.667-3-ansuelsmth@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | clk: qcom: Drop use of pxo/cxo_board for rpm devices | expand |
On Tue, 5 Jul 2022 at 23:56, Christian Marangi <ansuelsmth@gmail.com> wrote: > > Fix dtbs_check warning for new rpmcc Documentation changes and add the > required clocks. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm/boot/dts/qcom-apq8064.dtsi | 2 ++ > arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 ++ > arch/arm/boot/dts/qcom-msm8660.dtsi | 4 +++- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index 91adcbd54b17..6a88e616ea01 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -853,6 +853,8 @@ rpm@108000 { > rpmcc: clock-controller { > compatible = "qcom,rpmcc-apq8064", "qcom,rpmcc"; > #clock-cells = <1>; > + clocks = <&pxo_board>, <&cxo_board>; > + clock-names = "pxo", "cxo"; > }; > > regulators { > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 4b475d98343c..1425a4e4283f 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -773,6 +773,8 @@ rpm: rpm@108000 { > rpmcc: clock-controller { > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; > #clock-cells = <1>; > + clocks = <&pxo_board>; > + clock-names = "pxo"; > }; > }; > > diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi > index b9cded35b1cc..63a501c63cf8 100644 > --- a/arch/arm/boot/dts/qcom-msm8660.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi > @@ -56,7 +56,7 @@ cxo_board { > clock-frequency = <19200000>; > }; > > - pxo_board { > + pxo_board: pxo_board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <27000000>; > @@ -411,6 +411,8 @@ rpm: rpm@104000 { > rpmcc: clock-controller { > compatible = "qcom,rpmcc-msm8660", "qcom,rpmcc"; > #clock-cells = <1>; > + clocks = <&pxo_board>; > + clock-names = "pxo"; > }; > > pm8901-regulators { > -- > 2.36.1 >
On 05/07/2022 22:28, Christian Marangi wrote: > Fix dtbs_check warning for new rpmcc Documentation changes and add the > required clocks. There is no warning in the kernel, right? So the commit is not correct. Only the second part of your sentence applies, but you should extend it. Best regards, Krzysztof
On Wed, Jul 06, 2022 at 09:44:04AM +0200, Krzysztof Kozlowski wrote: > On 05/07/2022 22:28, Christian Marangi wrote: > > Fix dtbs_check warning for new rpmcc Documentation changes and add the > > required clocks. > > There is no warning in the kernel, right? So the commit is not correct. > Oh ok, the warning is generated by the new Documentation. > Only the second part of your sentence applies, but you should extend it. > Ok will reword this. > > > Best regards, > Krzysztof
diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi index 91adcbd54b17..6a88e616ea01 100644 --- a/arch/arm/boot/dts/qcom-apq8064.dtsi +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi @@ -853,6 +853,8 @@ rpm@108000 { rpmcc: clock-controller { compatible = "qcom,rpmcc-apq8064", "qcom,rpmcc"; #clock-cells = <1>; + clocks = <&pxo_board>, <&cxo_board>; + clock-names = "pxo", "cxo"; }; regulators { diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi index 4b475d98343c..1425a4e4283f 100644 --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi @@ -773,6 +773,8 @@ rpm: rpm@108000 { rpmcc: clock-controller { compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; #clock-cells = <1>; + clocks = <&pxo_board>; + clock-names = "pxo"; }; }; diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi index b9cded35b1cc..63a501c63cf8 100644 --- a/arch/arm/boot/dts/qcom-msm8660.dtsi +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi @@ -56,7 +56,7 @@ cxo_board { clock-frequency = <19200000>; }; - pxo_board { + pxo_board: pxo_board { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <27000000>; @@ -411,6 +411,8 @@ rpm: rpm@104000 { rpmcc: clock-controller { compatible = "qcom,rpmcc-msm8660", "qcom,rpmcc"; #clock-cells = <1>; + clocks = <&pxo_board>; + clock-names = "pxo"; }; pm8901-regulators {
Fix dtbs_check warning for new rpmcc Documentation changes and add the required clocks. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- arch/arm/boot/dts/qcom-apq8064.dtsi | 2 ++ arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 ++ arch/arm/boot/dts/qcom-msm8660.dtsi | 4 +++- 3 files changed, 7 insertions(+), 1 deletion(-)