diff mbox series

[RFC,1/4] clk: Use clk_core_unlink_consumer on __clk_put

Message ID 20220707100309.1357663-1-abel.vesa@linaro.org
State New
Headers show
Series [RFC,1/4] clk: Use clk_core_unlink_consumer on __clk_put | expand

Commit Message

Abel Vesa July 7, 2022, 10:03 a.m. UTC
For consistency, use clk_core_unlink_consumer rather then hlist_del
directly, on __clk_put. Prepare lock is already acquired at that point.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/clk/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Abel Vesa July 21, 2022, 8:17 a.m. UTC | #1
On 22-07-07 13:03:06, Abel Vesa wrote:
> For consistency, use clk_core_unlink_consumer rather then hlist_del
> directly, on __clk_put. Prepare lock is already acquired at that point.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>

Gentle ping.

> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 7fc191c15507..e1d8245866b1 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -4347,7 +4347,7 @@ void __clk_put(struct clk *clk)
>  		clk->exclusive_count = 0;
>  	}
>
> -	hlist_del(&clk->clks_node);
> +	clk_core_unlink_consumer(clk);
>  	if (clk->min_rate > clk->core->req_rate ||
>  	    clk->max_rate < clk->core->req_rate)
>  		clk_core_set_rate_nolock(clk->core, clk->core->req_rate);
> --
> 2.34.3
>
diff mbox series

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7fc191c15507..e1d8245866b1 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -4347,7 +4347,7 @@  void __clk_put(struct clk *clk)
 		clk->exclusive_count = 0;
 	}
 
-	hlist_del(&clk->clks_node);
+	clk_core_unlink_consumer(clk);
 	if (clk->min_rate > clk->core->req_rate ||
 	    clk->max_rate < clk->core->req_rate)
 		clk_core_set_rate_nolock(clk->core, clk->core->req_rate);