| Message ID | 20220712075859.875-1-quic_ppareek@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq | expand |
On Tue, Jul 12, 2022 at 01:28:59PM +0530, Parikshit Pareek wrote: > Remove the duplicate irq number 424, from apps_smmu node. This is needed > to correct the interrupt mapping for context banks. > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 7945cbb57bb4..9583cc53aa03 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1580,7 +1580,6 @@ > <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>, > -- > 2.17.1 > Looks good to me, thanks! Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
On Tue, Jul 12, 2022 at 01:28:59PM +0530, Parikshit Pareek wrote: > Remove the duplicate irq number 424, from apps_smmu node. This is needed > to correct the interrupt mapping for context banks. > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 7945cbb57bb4..9583cc53aa03 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1580,7 +1580,6 @@ > <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, While the change is correct, the IRQs are not sorted and that's what encouraging these kind of dups. Please sort them too. Thanks, Mani > <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>, > -- > 2.17.1 >
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 7945cbb57bb4..9583cc53aa03 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1580,7 +1580,6 @@ <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>,
Remove the duplicate irq number 424, from apps_smmu node. This is needed to correct the interrupt mapping for context banks. Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 - 1 file changed, 1 deletion(-)