diff mbox series

Bluetooth:btrtl:Fix typo in comment

Message ID 20220719154148.16769-1-dengshaomin@cdjrlc.com
State Superseded
Headers show
Series Bluetooth:btrtl:Fix typo in comment | expand

Commit Message

Shaomin Deng July 19, 2022, 3:41 p.m. UTC
Delete the repeated word "that" in comments.

Signed-off-by: shaomin Deng <dengshaomin@cdjrlc.com>
---
 drivers/bluetooth/btrtl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com July 19, 2022, 4:10 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=661165

---Test result---

Test Summary:
CheckPatch                    PASS      1.13 seconds
GitLint                       PASS      0.54 seconds
SubjectPrefix                 FAIL      0.40 seconds
BuildKernel                   PASS      33.58 seconds
BuildKernel32                 PASS      28.97 seconds
Incremental Build with patchesPASS      41.56 seconds
TestRunner: Setup             PASS      497.27 seconds
TestRunner: l2cap-tester      PASS      16.71 seconds
TestRunner: bnep-tester       PASS      5.57 seconds
TestRunner: mgmt-tester       PASS      96.20 seconds
TestRunner: rfcomm-tester     PASS      8.98 seconds
TestRunner: sco-tester        PASS      8.72 seconds
TestRunner: smp-tester        PASS      8.80 seconds
TestRunner: userchan-tester   PASS      5.75 seconds

Details
##############################
Test: SubjectPrefix - FAIL - 0.40 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth
Paul Menzel July 19, 2022, 7:28 p.m. UTC | #2
Dear Shaomin,


Am 19.07.22 um 17:41 schrieb shaomin Deng:
> Delete the repeated word "that" in comments.

Maybe start your first name with a capital letter?

     git config --global user.name "Shaomin Deng"

In the commit message summary, please add a space after the colons, and 
maybe use:

Bluetooth: btrtl: Remove duplicate *that* in comment

> 
> Signed-off-by: shaomin Deng <dengshaomin@cdjrlc.com>
> ---
>   drivers/bluetooth/btrtl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 47c28fd8f006..fb52313a1d45 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -330,7 +330,7 @@ static int rtlbt_parse_firmware(struct hci_dev *hdev,
>   	/* Loop from the end of the firmware parsing instructions, until
>   	 * we find an instruction that identifies the "project ID" for the
>   	 * hardware supported by this firwmare file.

firmware

It’d be great if you fixed that in a separate commit.

> -	 * Once we have that, we double-check that that project_id is suitable
> +	 * Once we have that, we double-check that project_id is suitable

It’s a lot of “that”, but it’s actually correct.

>   	 * for the hardware we are working with.
>   	 */
>   	while (fwptr >= btrtl_dev->fw_data + (sizeof(*epatch_info) + 3)) {


Kind regards,

Paul
diff mbox series

Patch

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 47c28fd8f006..fb52313a1d45 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -330,7 +330,7 @@  static int rtlbt_parse_firmware(struct hci_dev *hdev,
 	/* Loop from the end of the firmware parsing instructions, until
 	 * we find an instruction that identifies the "project ID" for the
 	 * hardware supported by this firwmare file.
-	 * Once we have that, we double-check that that project_id is suitable
+	 * Once we have that, we double-check that project_id is suitable
 	 * for the hardware we are working with.
 	 */
 	while (fwptr >= btrtl_dev->fw_data + (sizeof(*epatch_info) + 3)) {