| Message ID | 20220721090021.17005-1-shubhrajyoti.datta@xilinx.com |
|---|---|
| State | Accepted |
| Commit | f2a2f2c9aed21944095c2f867640a9089759c7e7 |
| Headers | show |
| Series | [v3] gpio: xilinx: add missing blank line after declarations | expand |
On 7/21/22 11:00, Shubhrajyoti Datta wrote: > Add a missing blank line. No functional changes. > > WARNING: Missing a blank line after declarations > 128: FILE: drivers/gpio/gpio-xilinx.c:120: > + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); > + xgpio_set_value32(a, bit, xgpio_readreg(addr)); > > WARNING: Missing a blank line after declarations > 136: FILE: drivers/gpio/gpio-xilinx.c:126: > + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); > + xgpio_writereg(addr, xgpio_get_value32(a, bit)); > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > v2: Update commit message > v3: No change > > drivers/gpio/gpio-xilinx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c > index b6d3a57e27ed..7f129e7eae78 100644 > --- a/drivers/gpio/gpio-xilinx.c > +++ b/drivers/gpio/gpio-xilinx.c > @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch) > static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a) > { > void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); > + > xgpio_set_value32(a, bit, xgpio_readreg(addr)); > } > > static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a) > { > void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); > + > xgpio_writereg(addr, xgpio_get_value32(a, bit)); > } > Reviewed-by: Michal Simek <michal.simek@amd.com> M
On Thu, Jul 21, 2022 at 11:00 AM Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> wrote: > > Add a missing blank line. No functional changes. > > WARNING: Missing a blank line after declarations > 128: FILE: drivers/gpio/gpio-xilinx.c:120: > + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); > + xgpio_set_value32(a, bit, xgpio_readreg(addr)); > > WARNING: Missing a blank line after declarations > 136: FILE: drivers/gpio/gpio-xilinx.c:126: > + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); > + xgpio_writereg(addr, xgpio_get_value32(a, bit)); > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> Applied, thanks! Bart
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c index b6d3a57e27ed..7f129e7eae78 100644 --- a/drivers/gpio/gpio-xilinx.c +++ b/drivers/gpio/gpio-xilinx.c @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch) static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a) { void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); + xgpio_set_value32(a, bit, xgpio_readreg(addr)); } static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a) { void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); + xgpio_writereg(addr, xgpio_get_value32(a, bit)); }
Add a missing blank line. No functional changes. WARNING: Missing a blank line after declarations 128: FILE: drivers/gpio/gpio-xilinx.c:120: + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); + xgpio_set_value32(a, bit, xgpio_readreg(addr)); WARNING: Missing a blank line after declarations 136: FILE: drivers/gpio/gpio-xilinx.c:126: + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32); + xgpio_writereg(addr, xgpio_get_value32(a, bit)); Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> --- v2: Update commit message v3: No change drivers/gpio/gpio-xilinx.c | 2 ++ 1 file changed, 2 insertions(+)