| Message ID | 20220722030938.2925156-1-williamsukatube@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe() | expand |
On 7/21/22 20:09, williamsukatube@163.com wrote: > From: William Dean <williamsukatube@gmail.com> > > The function devm_ioremap() in armada_37xx_wdt_probe() can fail, so > its return value should be checked. > > Fixes: 54e3d9b518c8a ("watchdog: Add support for Armada 37xx CPU watchdog") > Reported-by: Hacash Robot <hacashRobot@santino.com> > Signed-off-by: William Dean <williamsukatube@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/armada_37xx_wdt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada_37xx_wdt.c > index 1635f421ef2c..854b1cc723cb 100644 > --- a/drivers/watchdog/armada_37xx_wdt.c > +++ b/drivers/watchdog/armada_37xx_wdt.c > @@ -274,6 +274,8 @@ static int armada_37xx_wdt_probe(struct platform_device *pdev) > if (!res) > return -ENODEV; > dev->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res)); > + if (!dev->reg) > + return -ENOMEM; > > /* init clock */ > dev->clk = devm_clk_get(&pdev->dev, NULL);
diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada_37xx_wdt.c index 1635f421ef2c..854b1cc723cb 100644 --- a/drivers/watchdog/armada_37xx_wdt.c +++ b/drivers/watchdog/armada_37xx_wdt.c @@ -274,6 +274,8 @@ static int armada_37xx_wdt_probe(struct platform_device *pdev) if (!res) return -ENODEV; dev->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res)); + if (!dev->reg) + return -ENOMEM; /* init clock */ dev->clk = devm_clk_get(&pdev->dev, NULL);