| Message ID | 20220723201141.225812-1-marex@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode | expand |
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index c871602fc5ba9..d4e8146e38d57 100644 --- a/drivers/gpio/gpio-mxc.c +++ b/drivers/gpio/gpio-mxc.c @@ -204,6 +204,8 @@ static int gpio_set_irq_type(struct irq_data *d, u32 type) writel(1 << gpio_idx, port->base + GPIO_ISR); + writel(1 << gpio_idx, port->base + GPIO_GDIR); + return 0; }
Always configure GPIO pins which are used as interrupt source as INPUTs. In case the default pin configuration is OUTPUT, or the prior stage does configure the pins as OUTPUT, then Linux will not reconfigure the pin as INPUT and no interrupts are received. Always configure interrupt source GPIO pin as input to fix the above case. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Loic Poulain <loic.poulain@linaro.org> Cc: Marc Zyngier <maz@kernel.org> --- drivers/gpio/gpio-mxc.c | 2 ++ 1 file changed, 2 insertions(+)