diff mbox

[PULL,14/19] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

Message ID 8f32510f1ca72332b9a662579e951f67d636142e.1452501577.git.mjt@msgid.tls.msk.ru
State Accepted
Commit 8f32510f1ca72332b9a662579e951f67d636142e
Headers show

Commit Message

Michael Tokarev Jan. 11, 2016, 8:41 a.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>


The checkpatch.pl script has a special case to permit the following
operators to have no spaces around them:
 <<  >>  &  ^  |  +  -  *  /  %

QEMU style prefers all operators to consistently have spacing around
them, so remove this special case handling. This avoids reviewers
having to manually note it during code review.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Eric Blake <eblake@redhat.com>

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

---
 scripts/checkpatch.pl | 13 -------------
 1 file changed, 13 deletions(-)

-- 
2.1.4
diff mbox

Patch

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b0f6e11..efca817 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1890,19 +1890,6 @@  sub process {
 						ERROR("space prohibited after that '$op' $at\n" . $hereptr);
 					}
 
-
-				# << and >> may either have or not have spaces both sides
-				} elsif ($op eq '<<' or $op eq '>>' or
-					 $op eq '&' or $op eq '^' or $op eq '|' or
-					 $op eq '+' or $op eq '-' or
-					 $op eq '*' or $op eq '/' or
-					 $op eq '%')
-				{
-					if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
-						ERROR("need consistent spacing around '$op' $at\n" .
-							$hereptr);
-					}
-
 				# A colon needs no spaces before when it is
 				# terminating a case value or a label.
 				} elsif ($opv eq ':C' || $opv eq ':L') {