| Message ID | 20220803061618.1650538-1-ye.xingchen@zte.com.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [linux-next] eeprom: at24:using the pm_runtime_resume_and_get to simplify the code | expand |
On Wed, Aug 03, 2022 at 06:16:18AM +0000, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync > and pm_runtime_put_noidle. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/misc/eeprom/at24.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > index 633e1cf08d6e..f354b79619d8 100644 > --- a/drivers/misc/eeprom/at24.c > +++ b/drivers/misc/eeprom/at24.c > @@ -431,9 +431,8 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count) > if (off + count > at24->byte_len) > return -EINVAL; > > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > - pm_runtime_put_noidle(dev); > return ret; > } > > @@ -478,9 +477,8 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count) > if (off + count > at24->byte_len) > return -EINVAL; > > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > - pm_runtime_put_noidle(dev); > return ret; > } > > -- > 2.25.1 Again, please read: https://lore.kernel.org/r/YujeLEMsIrVD2tGn@kroah.com
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 633e1cf08d6e..f354b79619d8 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -431,9 +431,8 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count) if (off + count > at24->byte_len) return -EINVAL; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) { - pm_runtime_put_noidle(dev); return ret; } @@ -478,9 +477,8 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count) if (off + count > at24->byte_len) return -EINVAL; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) { - pm_runtime_put_noidle(dev); return ret; }