| Message ID | 20220801110440.13144-1-kvalo@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [wireless] wifi: wilc1000: fix spurious inline in wilc_handle_disconnect() | expand |
Kalle Valo <kvalo@kernel.org> wrote: > Sparse warns: > > drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition > > Remove the inline, it's not needed. > > Reported-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Kalle Valo <kvalo@kernel.org> > Acked-by: Ajay Singh <ajay.kathat@microchip.com> Patch applied to wireless.git, thanks. f01272ee3856 wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()
diff --git a/drivers/net/wireless/microchip/wilc1000/hif.c b/drivers/net/wireless/microchip/wilc1000/hif.c index b89519ab9205..eb1d1ba3a443 100644 --- a/drivers/net/wireless/microchip/wilc1000/hif.c +++ b/drivers/net/wireless/microchip/wilc1000/hif.c @@ -635,7 +635,7 @@ static inline void host_int_parse_assoc_resp_info(struct wilc_vif *vif, conn_info->req_ies_len = 0; } -inline void wilc_handle_disconnect(struct wilc_vif *vif) +void wilc_handle_disconnect(struct wilc_vif *vif) { struct host_if_drv *hif_drv = vif->hif_drv; diff --git a/drivers/net/wireless/microchip/wilc1000/hif.h b/drivers/net/wireless/microchip/wilc1000/hif.h index 69ba1d469e9f..baa2881f4465 100644 --- a/drivers/net/wireless/microchip/wilc1000/hif.h +++ b/drivers/net/wireless/microchip/wilc1000/hif.h @@ -215,5 +215,6 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length); void *wilc_parse_join_bss_param(struct cfg80211_bss *bss, struct cfg80211_crypto_settings *crypto); int wilc_set_default_mgmt_key_index(struct wilc_vif *vif, u8 index); -inline void wilc_handle_disconnect(struct wilc_vif *vif); +void wilc_handle_disconnect(struct wilc_vif *vif); + #endif
Sparse warns: drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition Remove the inline, it's not needed. Reported-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Kalle Valo <kvalo@kernel.org> --- drivers/net/wireless/microchip/wilc1000/hif.c | 2 +- drivers/net/wireless/microchip/wilc1000/hif.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) base-commit: 63757225a93353bc2ce4499af5501eabdbbf23f9