| Message ID | 20220810080516.166866-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | c77ad7f3ba7ffa05f49516732886f5feed95793b |
| Headers | show |
| Series | [1/4] ARM: dts: qcom: msm8960: override nodes by label | expand |
diff --git a/arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dts b/arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dts index d159188c8b95..290e1df631f0 100644 --- a/arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dts +++ b/arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dts @@ -18,8 +18,6 @@ chosen { }; }; -&soc { - serial@f991f000 { - status = "ok"; - }; +&blsp1_uart3 { + status = "ok"; };
Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). This also reduces the indentation making the code easier to read. The pre/post DTBS are the same. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)