diff mbox series

ACPI: APEI: Add bert error log footer

Message ID 1660554889-174857-1-git-send-email-dmtrmonakhov@yandex-team.ru
State Superseded
Headers show
Series ACPI: APEI: Add bert error log footer | expand

Commit Message

Dmitry Monakhov Aug. 15, 2022, 9:14 a.m. UTC
Print total number of records found during bert log parsing.
This also simplify dmesg parser implementation for bert events.

Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>

Comments

Rafael J. Wysocki Aug. 23, 2022, 4:29 p.m. UTC | #1
On Mon, Aug 15, 2022 at 11:22 AM Dmitry Monakhov
<dmtrmonakhov@yandex-team.ru> wrote:
>
> Print total number of records found during bert log parsing.

Please spell BERT in capitals everywhere, including the subject.

> This also simplify dmesg parser implementation for bert events.
>
> Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
>
> diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
> index 45973aa6e06d..c23eb75866d0 100644
> --- a/drivers/acpi/apei/bert.c
> +++ b/drivers/acpi/apei/bert.c
> @@ -90,6 +90,9 @@ static void __init bert_print_all(struct acpi_bert_region *region,
>
>         if (skipped)
>                 pr_info(HW_ERR "Skipped %d error records\n", skipped);
> +
> +       if (printed + skipped)
> +               pr_info("Total records found: %d\n", printed + skipped);
>  }
>
>  static int __init setup_bert_disable(char *str)
> --
> 2.7.4
>
Tony Luck Aug. 23, 2022, 4:37 p.m. UTC | #2
> +       if (printed + skipped)
> +               pr_info("Total records found: %d\n", printed + skipped);

Concept seems fine. So with the s/bert/BERT/ changes in subject and body.

Acked-by: Tony Luck <tony.luck@intel.com>

-Tony
diff mbox series

Patch

diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
index 45973aa6e06d..c23eb75866d0 100644
--- a/drivers/acpi/apei/bert.c
+++ b/drivers/acpi/apei/bert.c
@@ -90,6 +90,9 @@  static void __init bert_print_all(struct acpi_bert_region *region,
 
 	if (skipped)
 		pr_info(HW_ERR "Skipped %d error records\n", skipped);
+
+	if (printed + skipped)
+		pr_info("Total records found: %d\n", printed + skipped);
 }
 
 static int __init setup_bert_disable(char *str)