| Message ID | 20220816093644.764259-1-judyhsiao@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] arm64: dts: qcom: sc7280: Use "PP1800_L2C" as the DMIC power source. | expand |
Hi, On Tue, Aug 16, 2022 at 2:36 AM Judy Hsiao <judyhsiao@chromium.org> wrote: > > Use "PP1800_L2C" as the DMIC power source to match the hardware > schematic. > It fixes the DMIC no sound issue of villager-r1. > > > Co-developed-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> > --- > Changes since V1: > -- Update the commit message. > > > This patch depends on: > arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1] > > [1] > https://patchwork.kernel.org/patch/12926099/ > > > .../dts/qcom/sc7280-herobrine-villager-r1.dts | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > index c03b3ae4de50..983defa7c76d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > @@ -12,3 +12,31 @@ / { > model = "Google Villager (rev1+)"; > compatible = "google,villager", "qcom,sc7280"; > }; > + > +&lpass_va_macro { > + vdd-micb-supply = <&pp1800_l2c>; > +}; > + > +&sound { > + audio-routing = > + "IN1_HPHL", "HPHL_OUT", > + "IN2_HPHR", "HPHR_OUT", > + "AMIC1", "MIC BIAS1", > + "AMIC2", "MIC BIAS2", > + "VA DMIC0", "vdd-micb", > + "VA DMIC1", "vdd-micb", > + "VA DMIC2", "vdd-micb", > + "VA DMIC3", "vdd-micb", > + "TX SWR_ADC0", "ADC1_OUTPUT", > + "TX SWR_ADC1", "ADC2_OUTPUT", > + "TX SWR_ADC2", "ADC3_OUTPUT", > + "TX SWR_DMIC0", "DMIC1_OUTPUT", > + "TX SWR_DMIC1", "DMIC2_OUTPUT", > + "TX SWR_DMIC2", "DMIC3_OUTPUT", > + "TX SWR_DMIC3", "DMIC4_OUTPUT", > + "TX SWR_DMIC4", "DMIC5_OUTPUT", > + "TX SWR_DMIC5", "DMIC6_OUTPUT", > + "TX SWR_DMIC6", "DMIC7_OUTPUT", > + "TX SWR_DMIC7", "DMIC8_OUTPUT"; In v1, Stephen pointed out that the subject and description of your patch talk about adjusting the supply. However, your patch _also_ adjusts the audio routing. It feels like the audio routing should be done in a separate patch and that patch. -Doug
Hi, > In v1, Stephen pointed out that the subject and description of your > patch talk about adjusting the supply. However, your patch _also_ > adjusts the audio routing. Thanks for your comment. The audio routing part change is to use the vdd-micb-supply regulator setting. And the vdd-micb-supply set the MIC power source as PP1800_L2C. + "VA DMIC0", "vdd-micb", + "VA DMIC1", "vdd-micb", + "VA DMIC2", "vdd-micb", + "VA DMIC3", "vdd-micb", Let me update the commit message again to make it more clear. Thanks! > It feels like the audio routing should be done in a separate patch and > that patch. > > -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts index c03b3ae4de50..983defa7c76d 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts @@ -12,3 +12,31 @@ / { model = "Google Villager (rev1+)"; compatible = "google,villager", "qcom,sc7280"; }; + +&lpass_va_macro { + vdd-micb-supply = <&pp1800_l2c>; +}; + +&sound { + audio-routing = + "IN1_HPHL", "HPHL_OUT", + "IN2_HPHR", "HPHR_OUT", + "AMIC1", "MIC BIAS1", + "AMIC2", "MIC BIAS2", + "VA DMIC0", "vdd-micb", + "VA DMIC1", "vdd-micb", + "VA DMIC2", "vdd-micb", + "VA DMIC3", "vdd-micb", + "TX SWR_ADC0", "ADC1_OUTPUT", + "TX SWR_ADC1", "ADC2_OUTPUT", + "TX SWR_ADC2", "ADC3_OUTPUT", + "TX SWR_DMIC0", "DMIC1_OUTPUT", + "TX SWR_DMIC1", "DMIC2_OUTPUT", + "TX SWR_DMIC2", "DMIC3_OUTPUT", + "TX SWR_DMIC3", "DMIC4_OUTPUT", + "TX SWR_DMIC4", "DMIC5_OUTPUT", + "TX SWR_DMIC5", "DMIC6_OUTPUT", + "TX SWR_DMIC6", "DMIC7_OUTPUT", + "TX SWR_DMIC7", "DMIC8_OUTPUT"; + +};