diff mbox series

[2/2] PM: move from strlcpy with unused retval to strscpy

Message ID 20220818210156.8143-2-wsa+renesas@sang-engineering.com
State Accepted
Commit bd8092def983f567800f764a5d23b2dca98f078c
Headers show
Series None | expand

Commit Message

Wolfram Sang Aug. 18, 2022, 9:01 p.m. UTC
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 include/linux/suspend.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki Aug. 31, 2022, 7:17 p.m. UTC | #1
On Thu, Aug 18, 2022 at 11:05 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  include/linux/suspend.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index 70f2921e2e70..23a253df7f6b 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -75,7 +75,7 @@ extern struct suspend_stats suspend_stats;
>
>  static inline void dpm_save_failed_dev(const char *name)
>  {
> -       strlcpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
> +       strscpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
>                 name,
>                 sizeof(suspend_stats.failed_devs[0]));
>         suspend_stats.last_failed_dev++;
> --

Applied as 6.1 material, thanks!
diff mbox series

Patch

diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index 70f2921e2e70..23a253df7f6b 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -75,7 +75,7 @@  extern struct suspend_stats suspend_stats;
 
 static inline void dpm_save_failed_dev(const char *name)
 {
-	strlcpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
+	strscpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
 		name,
 		sizeof(suspend_stats.failed_devs[0]));
 	suspend_stats.last_failed_dev++;