diff mbox series

drm/msm: fix repeated words in comments

Message ID 20220823115409.46653-1-yuanjilin@cdjrlc.com
State New
Headers show
Series drm/msm: fix repeated words in comments | expand

Commit Message

Jilin Yuan Aug. 23, 2022, 11:54 a.m. UTC
Delete the redundant word 'one'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/gpu/drm/msm/msm_gem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Baryshkov Aug. 26, 2022, 9:43 a.m. UTC | #1
On 23/08/2022 14:54, Jilin Yuan wrote:
>   Delete the redundant word 'one'.

The whitespace is unnecessary.

> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")


> ---
>   drivers/gpu/drm/msm/msm_gem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> index c75d3b879a53..e300c70e8904 100644
> --- a/drivers/gpu/drm/msm/msm_gem.h
> +++ b/drivers/gpu/drm/msm/msm_gem.h
> @@ -118,7 +118,7 @@ struct msm_gem_object {
>   	 * An object is either:
>   	 *  inactive - on priv->inactive_dontneed or priv->inactive_willneed
>   	 *     (depending on purgeability status)
> -	 *  active   - on one one of the gpu's active_list..  well, at
> +	 *  active   - on one of the gpu's active_list..  well, at
>   	 *     least for now we don't have (I don't think) hw sync between
>   	 *     2d and 3d one devices which have both, meaning we need to
>   	 *     block on submit if a bo is already on other ring
Rob Clark Aug. 27, 2022, 4:42 p.m. UTC | #2
On Fri, Aug 26, 2022 at 2:43 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 23/08/2022 14:54, Jilin Yuan wrote:
> >   Delete the redundant word 'one'.
>
> The whitespace is unnecessary.
>
> >
> > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")
>

jfyi, this comment (and associated list-head) is removed by:

https://patchwork.freedesktop.org/patch/496131/?series=105633&rev=4

BR,
-R

>
> > ---
> >   drivers/gpu/drm/msm/msm_gem.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> > index c75d3b879a53..e300c70e8904 100644
> > --- a/drivers/gpu/drm/msm/msm_gem.h
> > +++ b/drivers/gpu/drm/msm/msm_gem.h
> > @@ -118,7 +118,7 @@ struct msm_gem_object {
> >        * An object is either:
> >        *  inactive - on priv->inactive_dontneed or priv->inactive_willneed
> >        *     (depending on purgeability status)
> > -      *  active   - on one one of the gpu's active_list..  well, at
> > +      *  active   - on one of the gpu's active_list..  well, at
> >        *     least for now we don't have (I don't think) hw sync between
> >        *     2d and 3d one devices which have both, meaning we need to
> >        *     block on submit if a bo is already on other ring
>
> --
> With best wishes
> Dmitry
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
index c75d3b879a53..e300c70e8904 100644
--- a/drivers/gpu/drm/msm/msm_gem.h
+++ b/drivers/gpu/drm/msm/msm_gem.h
@@ -118,7 +118,7 @@  struct msm_gem_object {
 	 * An object is either:
 	 *  inactive - on priv->inactive_dontneed or priv->inactive_willneed
 	 *     (depending on purgeability status)
-	 *  active   - on one one of the gpu's active_list..  well, at
+	 *  active   - on one of the gpu's active_list..  well, at
 	 *     least for now we don't have (I don't think) hw sync between
 	 *     2d and 3d one devices which have both, meaning we need to
 	 *     block on submit if a bo is already on other ring