diff mbox series

[v1,3/4] usb: typec: tcpci_maxim: Export helper function for register reads

Message ID 20220826084001.3341215-3-badhri@google.com
State New
Headers show
Series [v1,1/4] usb: typec: tcpm: Add callbacks to mitigate wakeups due to contaminant | expand

Commit Message

Badhri Jagan Sridharan Aug. 26, 2022, 8:40 a.m. UTC 
Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
---
 drivers/usb/typec/tcpm/tcpci_maxim.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Greg Kroah-Hartman Aug. 30, 2022, 1 p.m. UTC | #1 
On Fri, Aug 26, 2022 at 01:40:00AM -0700, Badhri Jagan Sridharan wrote:
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>

As Heikki pointed out, I can not accept changes with no changelog text
at all, you know this.

Please write a good changelog text that explains why you are doing this
so we can properly review it.  As it is, we have no idea what is going
on here at all.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
index 4b6705f3d7b7..af3a7ecab23b 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
@@ -68,25 +68,29 @@  static struct max_tcpci_chip *tdata_to_max_tcpci(struct tcpci_data *tdata)
 	return container_of(tdata, struct max_tcpci_chip, data);
 }
 
-static int max_tcpci_read16(struct max_tcpci_chip *chip, unsigned int reg, u16 *val)
+inline int max_tcpci_read16(struct max_tcpci_chip *chip, unsigned int reg, u16 *val)
 {
 	return regmap_raw_read(chip->data.regmap, reg, val, sizeof(u16));
 }
+EXPORT_SYMBOL_GPL(max_tcpci_read16);
 
-static int max_tcpci_write16(struct max_tcpci_chip *chip, unsigned int reg, u16 val)
+inline int max_tcpci_write16(struct max_tcpci_chip *chip, unsigned int reg, u16 val)
 {
 	return regmap_raw_write(chip->data.regmap, reg, &val, sizeof(u16));
 }
+EXPORT_SYMBOL_GPL(max_tcpci_write16);
 
-static int max_tcpci_read8(struct max_tcpci_chip *chip, unsigned int reg, u8 *val)
+inline int max_tcpci_read8(struct max_tcpci_chip *chip, unsigned int reg, u8 *val)
 {
 	return regmap_raw_read(chip->data.regmap, reg, val, sizeof(u8));
 }
+EXPORT_SYMBOL_GPL(max_tcpci_read8);
 
-static int max_tcpci_write8(struct max_tcpci_chip *chip, unsigned int reg, u8 val)
+inline int max_tcpci_write8(struct max_tcpci_chip *chip, unsigned int reg, u8 val)
 {
 	return regmap_raw_write(chip->data.regmap, reg, &val, sizeof(u8));
 }
+EXPORT_SYMBOL_GPL(max_tcpci_write8);
 
 static void max_tcpci_init_regs(struct max_tcpci_chip *chip)
 {