| Message ID | 20220828132648.3624126-2-bryan.odonoghue@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: pwm: Drop PWM reg dependency | expand |
On 28/08/2022 15:26, Bryan O'Donoghue wrote: > The PWM node is not a separate device and is expected to be part of parent > SPMI PMIC node, thus it obtains the address space from the parent. One IO > address in "reg" is also not correct description because LPG block maps to > several regions. > > Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC") > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- This still waits for merging... probably because maintainers were not Cced. Bryan, please use scripts/get_maintainers.pl to Cc necessary people. Otherwise your patch won't be applied. Best regards, Krzysztof
On 26/09/2022 16:15, Krzysztof Kozlowski wrote: > On 28/08/2022 15:26, Bryan O'Donoghue wrote: >> The PWM node is not a separate device and is expected to be part of parent >> SPMI PMIC node, thus it obtains the address space from the parent. One IO >> address in "reg" is also not correct description because LPG block maps to >> several regions. >> >> Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC") >> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- > > This still waits for merging... probably because maintainers were not > Cced. Bryan, please use scripts/get_maintainers.pl to Cc necessary > people. Otherwise your patch won't be applied. Maitainers were cc'd I have Andy, Bjorn, Rob and yourself on the list here. scripts/get_maintainer.pl Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT) Bjorn Andersson <bjorn.andersson@linaro.org> (maintainer:ARM/QUALCOMM SUPPORT) Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT) Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD)) Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Stephen Boyd <sboyd@kernel.org> (in file) linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT) devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-kernel@vger.kernel.org (open list) --- bod
On 26/09/2022 17:59, Bryan O'Donoghue wrote: > On 26/09/2022 16:15, Krzysztof Kozlowski wrote: >> On 28/08/2022 15:26, Bryan O'Donoghue wrote: >>> The PWM node is not a separate device and is expected to be part of parent >>> SPMI PMIC node, thus it obtains the address space from the parent. One IO >>> address in "reg" is also not correct description because LPG block maps to >>> several regions. >>> >>> Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC") >>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >>> --- >>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- >> >> This still waits for merging... probably because maintainers were not >> Cced. Bryan, please use scripts/get_maintainers.pl to Cc necessary >> people. Otherwise your patch won't be applied. > > Maitainers were cc'd > > I have Andy, Bjorn, Rob and yourself on the list here. And these are not the maintainers who will pick up this patch, so they are not enough. > > scripts/get_maintainer.pl > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > > Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT) > Bjorn Andersson <bjorn.andersson@linaro.org> (maintainer:ARM/QUALCOMM > SUPPORT) > Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT) > Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD)) MFD patches go via Lee. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 65cbc6dee545e..2a5bafe0660a0 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -92,6 +92,10 @@ properties: type: object $ref: /schemas/regulator/regulator.yaml# + pwm: + type: object + $ref: /schemas/leds/leds-qcom-lpg.yaml# + patternProperties: "^adc@[0-9a-f]+$": type: object @@ -117,10 +121,6 @@ patternProperties: type: object $ref: /schemas/power/reset/qcom,pon.yaml# - "pwm@[0-9a-f]+$": - type: object - $ref: /schemas/leds/leds-qcom-lpg.yaml# - "^rtc@[0-9a-f]+$": type: object $ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
The PWM node is not a separate device and is expected to be part of parent SPMI PMIC node, thus it obtains the address space from the parent. One IO address in "reg" is also not correct description because LPG block maps to several regions. Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC") Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)