| Message ID | 92aaf098d7039fd4040015b07ba1f99daf674f50.1661789204.git.christophe.leroy@csgroup.eu |
|---|---|
| State | Superseded |
| Headers | show |
| Series | gpio: Get rid of ARCH_NR_GPIOS (v1) | expand |
Le 30/08/2022 à 22:14, Andy Shevchenko a écrit : > On Mon, Aug 29, 2022 at 7:18 PM Christophe Leroy > <christophe.leroy@csgroup.eu> wrote: >> >> In the preparation of getting completely rid of static gpiobase >> allocation in the future, emit a warning in drivers still doing so. > > ... > >> + dev_warn(&gdev->dev, "Static allocation of GPIO base is " >> + "deprecated, use dynamic allocation."); > > First of all, do not split string literals. Second, you forgot '\n'. > Then I get a line longer than 100 chars, is that acceptable ? Since commit 5fd29d6ccbc9 ("printk: clean up handling of log-levels and newlines"), "\n" are just visual pollution, aren't they ? Christophe
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index cc9c0a12259e..3a6f29eeb72d 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -715,6 +715,9 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, * a poison instead. */ gc->base = base; + } else { + dev_warn(&gdev->dev, "Static allocation of GPIO base is " + "deprecated, use dynamic allocation."); } gdev->base = base;
In the preparation of getting completely rid of static gpiobase allocation in the future, emit a warning in drivers still doing so. Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> --- drivers/gpio/gpiolib.c | 3 +++ 1 file changed, 3 insertions(+)