| Message ID | 20220830103456.3249168-1-sakari.ailus@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 54bb7671ca6de58929b3994468c330bedb9a3b7e |
| Headers | show |
| Series | [1/1] ar0521: Fix return value check in writing initial registers | expand |
Hi Sakari, Sakari Ailus <sakari.ailus@linux.intel.com> writes: > The return value from register writes is ignored apart from the last > value. Fix this. Must be Emacs' fault :-) > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Krzysztof Hałasa <khalasa@piap.pl> > +++ b/drivers/media/i2c/ar0521.c > @@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev) > gpiod_set_value(sensor->reset_gpio, 0); > usleep_range(4500, 5000); /* min 45000 clocks */ > > - for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) > + for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) { > ret = ar0521_write_regs(sensor, initial_regs[cnt].data, > initial_regs[cnt].count); > if (ret) > goto off; > + }
diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c index 9e90b02b15e36..a586e0fc0ea3f 100644 --- a/drivers/media/i2c/ar0521.c +++ b/drivers/media/i2c/ar0521.c @@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev) gpiod_set_value(sensor->reset_gpio, 0); usleep_range(4500, 5000); /* min 45000 clocks */ - for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) + for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) { ret = ar0521_write_regs(sensor, initial_regs[cnt].data, initial_regs[cnt].count); if (ret) goto off; + } ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT, AR0521_REG_SERIAL_FORMAT_MIPI |
The return value from register writes is ignored apart from the last value. Fix this. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/i2c/ar0521.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)