| Message ID | 20220901024827.v3.1.I3aa360986c0e7377ea5e96c116f014ff1ab8c968@changeid |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 | expand |
Bjorn, On Wed, Aug 31, 2022 at 7:50 PM Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> wrote: > > pazquel360 is an extension project based on pazquel. > We create 3 sku on pazquel360: > sku 20 for LTE with physical SIM _and_ eSIM and WiFi > sku 21 for WiFi only > sku 22 for LTE with only a physical SIM > Both sku20 and sku22 are LTE SKUs. > One has the eSIM stuffed and one doesn't. > There is a single shared device tree for the two. > > Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > --- > > Changes in v3: > 1. Adjust the format of the changelog. > > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) I think these two patches are ready to land if now is a good time. Thanks! -Doug
Hi, On Mon, Oct 17, 2022 at 8:15 PM Bjorn Andersson <andersson@kernel.org> wrote: > > On Thu, 1 Sep 2022 02:49:57 +0000, Yunlong Jia wrote: > > pazquel360 is an extension project based on pazquel. > > We create 3 sku on pazquel360: > > sku 20 for LTE with physical SIM _and_ eSIM and WiFi > > sku 21 for WiFi only > > sku 22 for LTE with only a physical SIM > > Both sku20 and sku22 are LTE SKUs. > > One has the eSIM stuffed and one doesn't. > > There is a single shared device tree for the two. > > > > [...] > > Applied, thanks! > > [1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 > commit: 185d192d0a7b565a24b3f7456a2f84f169ab087a > [2/2] arm64: dts: qcom: Add sc7180-pazquel360 > commit: 2f72a4f54cdb4fd0ebea9a2dea65756d3e676be2 FWIW, it looks like you landed v3 instead of v5. See: https://lore.kernel.org/r/20220923083657.v5.3.Iea2d2918adfff2825b87d428b5732717425c196f@changeid/ Presumably something about your process got confused because Yunlong changed the email address they were sending it from (I think someone requested not to use an "corp-partner" email address). The other difference between v3 and v5 is the touchscreen. Presumably Yunlong can send a followup patch to add the touchscreen atop what you've landed. -Doug
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index fb1d00bcc847..851cf5edb582 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -459,6 +459,17 @@ properties: - const: google,pazquel-sku2 - const: qcom,sc7180 + - description: Google Pazquel360 with LTE (newest rev) + items: + - const: google,pazquel-sku22 + - const: google,pazquel-sku20 + - const: qcom,sc7180 + + - description: Google Pazquel360 with WiFi (newest rev) + items: + - const: google,pazquel-sku21 + - const: qcom,sc7180 + - description: Sharp Dynabook Chromebook C1 (rev1) items: - const: google,pompom-rev1