diff mbox series

ACPI / property: Silence missing-declarations warning in apple.c

Message ID a6030c5943ccd2965261a92320b1ae1adb909116.1662084833.git.lukas@wunner.de
State Accepted
Commit a1cf1fd62ae71b585b35f78f8bcf6b1bc9de2c40
Headers show
Series ACPI / property: Silence missing-declarations warning in apple.c | expand

Commit Message

Lukas Wunner Sept. 2, 2022, 2:15 a.m. UTC
Silence an annoying message emitted for W=1 builds:

drivers/acpi/x86/apple.c:30:6: warning: no previous declaration for 'acpi_extract_apple_properties' [-Wmissing-declarations]

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 drivers/acpi/x86/apple.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andy Shevchenko Sept. 2, 2022, 9:47 a.m. UTC | #1
On Fri, Sep 02, 2022 at 04:15:55AM +0200, Lukas Wunner wrote:
> Silence an annoying message emitted for W=1 builds:
> 
> drivers/acpi/x86/apple.c:30:6: warning: no previous declaration for 'acpi_extract_apple_properties' [-Wmissing-declarations]

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
>  drivers/acpi/x86/apple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/acpi/x86/apple.c b/drivers/acpi/x86/apple.c
> index c285c91a5e9c..8812ecd03d55 100644
> --- a/drivers/acpi/x86/apple.c
> +++ b/drivers/acpi/x86/apple.c
> @@ -8,6 +8,7 @@
>  #include <linux/bitmap.h>
>  #include <linux/platform_data/x86/apple.h>
>  #include <linux/uuid.h>
> +#include "../internal.h"
>  
>  /* Apple _DSM device properties GUID */
>  static const guid_t apple_prp_guid =
> -- 
> 2.36.1
>
Rafael J. Wysocki Sept. 3, 2022, 7 p.m. UTC | #2
On Fri, Sep 2, 2022 at 11:50 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Fri, Sep 02, 2022 at 04:15:55AM +0200, Lukas Wunner wrote:
> > Silence an annoying message emitted for W=1 builds:
> >
> > drivers/acpi/x86/apple.c:30:6: warning: no previous declaration for 'acpi_extract_apple_properties' [-Wmissing-declarations]
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> > ---
> >  drivers/acpi/x86/apple.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/acpi/x86/apple.c b/drivers/acpi/x86/apple.c
> > index c285c91a5e9c..8812ecd03d55 100644
> > --- a/drivers/acpi/x86/apple.c
> > +++ b/drivers/acpi/x86/apple.c
> > @@ -8,6 +8,7 @@
> >  #include <linux/bitmap.h>
> >  #include <linux/platform_data/x86/apple.h>
> >  #include <linux/uuid.h>
> > +#include "../internal.h"
> >
> >  /* Apple _DSM device properties GUID */
> >  static const guid_t apple_prp_guid =
> > --

Applied as 6.1 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/x86/apple.c b/drivers/acpi/x86/apple.c
index c285c91a5e9c..8812ecd03d55 100644
--- a/drivers/acpi/x86/apple.c
+++ b/drivers/acpi/x86/apple.c
@@ -8,6 +8,7 @@ 
 #include <linux/bitmap.h>
 #include <linux/platform_data/x86/apple.h>
 #include <linux/uuid.h>
+#include "../internal.h"
 
 /* Apple _DSM device properties GUID */
 static const guid_t apple_prp_guid =