[1/1] sun6i-mipi-csi2: Depend on PHY_SUN6I_MIPI_DPHY

PHY_SUN6I_MIPI_DPHY is not a freely selectable option and so may not
always be available. Depend on it instead.

Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Sakari,

On Mon 05 Sep 22, 13:00, Sakari Ailus wrote:
> PHY_SUN6I_MIPI_DPHY is not a freely selectable option and so may not
> always be available. Depend on it instead.

I don't get what you mean by "not a freely selectable option".
It's definitely a tristate. Also no build issue will occur if it's
unselected (but I guess that's not the point here).

Cheers,

Paul
 
> Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> index eb982466abd30..4d072abdfb705 100644
> --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> @@ -4,10 +4,10 @@ config VIDEO_SUN6I_MIPI_CSI2
>  	depends on V4L_PLATFORM_DRIVERS && VIDEO_DEV
>  	depends on ARCH_SUNXI || COMPILE_TEST
>  	depends on PM && COMMON_CLK
> +	depends on PHY_SUN6I_MIPI_DPHY
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select V4L2_FWNODE
> -	select PHY_SUN6I_MIPI_DPHY
>  	select GENERIC_PHY_MIPI_DPHY
>  	select REGMAP_MMIO
>  	help
> -- 
> 2.30.2
>

Hi Paul,

On Fri, Sep 09, 2022 at 04:00:37PM +0200, Paul Kocialkowski wrote:
> Hi Sakari,
> 
> On Mon 05 Sep 22, 13:00, Sakari Ailus wrote:
> > PHY_SUN6I_MIPI_DPHY is not a freely selectable option and so may not
> > always be available. Depend on it instead.
> 
> I don't get what you mean by "not a freely selectable option".
> It's definitely a tristate. Also no build issue will occur if it's
> unselected (but I guess that's not the point here).

It depends on a number of other configuration options. You can force the
value of the option itself but not its dependencies. This can lead to build
errors dependin on the values of the options PHY_SUN6I_MIPI_DPHY needs.

Hi Sakari,

On Fri 09 Sep 22, 14:36, Sakari Ailus wrote:
> Hi Paul,
> 
> On Fri, Sep 09, 2022 at 04:00:37PM +0200, Paul Kocialkowski wrote:
> > Hi Sakari,
> > 
> > On Mon 05 Sep 22, 13:00, Sakari Ailus wrote:
> > > PHY_SUN6I_MIPI_DPHY is not a freely selectable option and so may not
> > > always be available. Depend on it instead.
> > 
> > I don't get what you mean by "not a freely selectable option".
> > It's definitely a tristate. Also no build issue will occur if it's
> > unselected (but I guess that's not the point here).
> 
> It depends on a number of other configuration options. You can force the
> value of the option itself but not its dependencies. This can lead to build
> errors dependin on the values of the options PHY_SUN6I_MIPI_DPHY needs.

Ah yes I see, it's the usual issue with select selecting the option regardless
of its dependencies. My bad.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Thanks,

Paul