diff mbox series

[01/11] dt-bindings: msm: dsi-controller-main: Drop redundant phy-names

Message ID 20220907000105.786265-2-bryan.odonoghue@linaro.org
State Accepted
Commit c54155622c29297560a0840640e2d7431add2cb3
Headers show
Series qcom,mdss-dsi-ctrl: Remove redundant phy-names from yaml and dtsi | expand

Commit Message

Bryan O'Donoghue Sept. 7, 2022, midnight UTC
Adding in msm8939 which is based msm8916 dtsi I stumbled across a binding
check complaining about the phy name for msm8916 which we were reusing for
msm8939.

The currently inconsistent upstream dtsi naming of "dsi" and "dsi-phy" is
not captured in the yaml for this driver.

The driver however doesn't care about the name of DSI phy, hence the yaml
check is redundant.

Both Krzysztof and Rob suggested we could drop the phy-names entirely if it
really isn't a dependency.

So, drop the inconsistent and unnecessary phy-names field from the yaml.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 .../devicetree/bindings/display/msm/dsi-controller-main.yaml    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 8, 2022, 2:11 p.m. UTC | #1
On 07/09/2022 02:00, Bryan O'Donoghue wrote:
> Adding in msm8939 which is based msm8916 dtsi I stumbled across a binding
> check complaining about the phy name for msm8916 which we were reusing for
> msm8939.
> 
> The currently inconsistent upstream dtsi naming of "dsi" and "dsi-phy" is
> not captured in the yaml for this driver.
> 
> The driver however doesn't care about the name of DSI phy, hence the yaml
> check is redundant.
> 
> Both Krzysztof and Rob suggested we could drop the phy-names entirely if it
> really isn't a dependency.
> 
> So, drop the inconsistent and unnecessary phy-names field from the yaml.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Dmitry Baryshkov Sept. 8, 2022, 10:31 p.m. UTC | #2
On 07/09/2022 03:00, Bryan O'Donoghue wrote:
> Adding in msm8939 which is based msm8916 dtsi I stumbled across a binding
> check complaining about the phy name for msm8916 which we were reusing for
> msm8939.
> 
> The currently inconsistent upstream dtsi naming of "dsi" and "dsi-phy" is
> not captured in the yaml for this driver.
> 
> The driver however doesn't care about the name of DSI phy, hence the yaml
> check is redundant.
> 
> Both Krzysztof and Rob suggested we could drop the phy-names entirely if it
> really isn't a dependency.
> 
> So, drop the inconsistent and unnecessary phy-names field from the yaml.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>   .../devicetree/bindings/display/msm/dsi-controller-main.yaml    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 880bfe930830c..3742e2ab4fb1d 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -49,6 +49,7 @@ properties:
>       maxItems: 1
>   
>     phy-names:
> +    deprecated: true
>       const: dsi
>   
>     "#address-cells": true
> @@ -133,7 +134,6 @@ required:
>     - clocks
>     - clock-names
>     - phys
> -  - phy-names
>     - assigned-clocks
>     - assigned-clock-parents
>     - power-domains
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 880bfe930830c..3742e2ab4fb1d 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -49,6 +49,7 @@  properties:
     maxItems: 1
 
   phy-names:
+    deprecated: true
     const: dsi
 
   "#address-cells": true
@@ -133,7 +134,6 @@  required:
   - clocks
   - clock-names
   - phys
-  - phy-names
   - assigned-clocks
   - assigned-clock-parents
   - power-domains