| Message ID | 20220907070001.19867-1-lukas.bulwahn@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 | expand |
On 09/07/2022 12:00 AM, Lukas Bulwahn wrote: > Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA") > removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent. > > Probably due to concurrent development, commit a0ba692072d8 ("leds: > bcm63138: add support for BCM63138 controller") introduces 'LED Support > for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was > not visible during the config refactoring from the commit above. Hence, > these two changes create a reference to a non-existing config symbol. > > Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of > ARCH_BCM4908 to remove the reference to the non-existing config symbol > ARCH_BCM4908. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > drivers/leds/blink/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig > index 945c84286a4e..bdcb7377cd4e 100644 > --- a/drivers/leds/blink/Kconfig > +++ b/drivers/leds/blink/Kconfig > @@ -1,10 +1,10 @@ > config LEDS_BCM63138 > tristate "LED Support for Broadcom BCM63138 SoC" > depends on LEDS_CLASS > - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST > + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST > depends on HAS_IOMEM > depends on OF > - default ARCH_BCM4908 > + default ARCH_BCMBCA > help > This option enables support for LED controller that is part of > BCM63138 SoC. The same hardware block is known to be also used > Acked-by: William Zhang <william.zhang@broadcom.com>
On 9/7/2022 12:00 AM, Lukas Bulwahn wrote: > Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA") > removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent. > > Probably due to concurrent development, commit a0ba692072d8 ("leds: > bcm63138: add support for BCM63138 controller") introduces 'LED Support > for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was > not visible during the config refactoring from the commit above. Hence, > these two changes create a reference to a non-existing config symbol. > > Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of > ARCH_BCM4908 to remove the reference to the non-existing config symbol > ARCH_BCM4908. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig index 945c84286a4e..bdcb7377cd4e 100644 --- a/drivers/leds/blink/Kconfig +++ b/drivers/leds/blink/Kconfig @@ -1,10 +1,10 @@ config LEDS_BCM63138 tristate "LED Support for Broadcom BCM63138 SoC" depends on LEDS_CLASS - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST depends on HAS_IOMEM depends on OF - default ARCH_BCM4908 + default ARCH_BCMBCA help This option enables support for LED controller that is part of BCM63138 SoC. The same hardware block is known to be also used
Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA") removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent. Probably due to concurrent development, commit a0ba692072d8 ("leds: bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol. Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of ARCH_BCM4908 to remove the reference to the non-existing config symbol ARCH_BCM4908. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- drivers/leds/blink/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)