| Message ID | 20220908181432.458900-1-stephan.gerhold@kernkonzept.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: remoteproc: qcom,smd-edge: Add APR/FastRPC | expand |
On 08/09/2022 20:14, Stephan Gerhold wrote: > Similar to qcom,glink-edge.yaml the smd-edge can also contain > apr/fastrpc nodes for functionality exposed by the modem or audio DSP. > > These nodes are already used in existing device trees, adding them > fixes the following dtbs_check warnings after converting > qcom,msm8916-mss-pil to DT schema: > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: smd-edge: > Unevaluated properties are not allowed ('fastrpc' was unexpected) > From schema: remoteproc/qcom,msm8916-mss-pil.yaml > > Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 08/09/2022 20:14, Stephan Gerhold wrote: > Similar to qcom,glink-edge.yaml the smd-edge can also contain > apr/fastrpc nodes for functionality exposed by the modem or audio DSP. > > These nodes are already used in existing device trees, adding them > fixes the following dtbs_check warnings after converting > qcom,msm8916-mss-pil to DT schema: > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: smd-edge: > Unevaluated properties are not allowed ('fastrpc' was unexpected) > From schema: remoteproc/qcom,msm8916-mss-pil.yaml > > Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> > --- > Since qcom,fastrpc.yaml only exists in Rob's tree right now and > a similar change for qcom,glink-edge.yaml was applied there it is > probably easiest if this patch goes through Rob's tree as well. I forgot you sent it, so I need to rebase my series: https://lore.kernel.org/linux-devicetree/20220909125403.803158-1-krzysztof.kozlowski@linaro.org/T/#t Best regards, Krzysztof
On 09/09/2022 18:22, Rob Herring wrote: > On Fri, Sep 9, 2022 at 11:16 AM Rob Herring <robh@kernel.org> wrote: >> >> On Thu, 08 Sep 2022 20:14:32 +0200, Stephan Gerhold wrote: >>> Similar to qcom,glink-edge.yaml the smd-edge can also contain >>> apr/fastrpc nodes for functionality exposed by the modem or audio DSP. >>> >>> These nodes are already used in existing device trees, adding them >>> fixes the following dtbs_check warnings after converting >>> qcom,msm8916-mss-pil to DT schema: >>> >>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: smd-edge: >>> Unevaluated properties are not allowed ('fastrpc' was unexpected) >>> From schema: remoteproc/qcom,msm8916-mss-pil.yaml >>> >>> Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> >>> --- >>> Since qcom,fastrpc.yaml only exists in Rob's tree right now and >>> a similar change for qcom,glink-edge.yaml was applied there it is >>> probably easiest if this patch goes through Rob's tree as well. >>> --- >>> .../devicetree/bindings/remoteproc/qcom,smd-edge.yaml | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >> >> Applied, thanks! > > And dropped for Krzysztof's series instead. Technically Stephan was first and his patch solves it in partial way, yet still self-contained way. I am fine rebasing my patchset on top of it. Best regards, Krzysztof
On Fri, Sep 09, 2022 at 06:30:11PM +0200, Krzysztof Kozlowski wrote: > On 09/09/2022 18:22, Rob Herring wrote: > > On Fri, Sep 9, 2022 at 11:16 AM Rob Herring <robh@kernel.org> wrote: > >> > >> On Thu, 08 Sep 2022 20:14:32 +0200, Stephan Gerhold wrote: > >>> Similar to qcom,glink-edge.yaml the smd-edge can also contain > >>> apr/fastrpc nodes for functionality exposed by the modem or audio DSP. > >>> > >>> These nodes are already used in existing device trees, adding them > >>> fixes the following dtbs_check warnings after converting > >>> qcom,msm8916-mss-pil to DT schema: > >>> > >>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: smd-edge: > >>> Unevaluated properties are not allowed ('fastrpc' was unexpected) > >>> From schema: remoteproc/qcom,msm8916-mss-pil.yaml > >>> > >>> Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> > >>> --- > >>> Since qcom,fastrpc.yaml only exists in Rob's tree right now and > >>> a similar change for qcom,glink-edge.yaml was applied there it is > >>> probably easiest if this patch goes through Rob's tree as well. > >>> --- > >>> .../devicetree/bindings/remoteproc/qcom,smd-edge.yaml | 10 ++++++++++ > >>> 1 file changed, 10 insertions(+) > >>> > >> > >> Applied, thanks! > > > > And dropped for Krzysztof's series instead. > > Technically Stephan was first and his patch solves it in partial way, > yet still self-contained way. I am fine rebasing my patchset on top of it. > Feel free to skip this patch if your series contains equivalent changes. I mainly submitted this to unblock my qcom,msm8916-mss-pil.yaml series so I'm fine as long as equivalent changes have been applied. :) Thanks, Stephan
On 09/09/2022 18:45, Stephan Gerhold wrote: >>> And dropped for Krzysztof's series instead. >> >> Technically Stephan was first and his patch solves it in partial way, >> yet still self-contained way. I am fine rebasing my patchset on top of it. >> > > Feel free to skip this patch if your series contains equivalent changes. > I mainly submitted this to unblock my qcom,msm8916-mss-pil.yaml series > so I'm fine as long as equivalent changes have been applied. :) Thanks Stephan! Your work is much appreciated! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml index 06eebf791e32..9b9eaa80fd20 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml @@ -19,6 +19,16 @@ properties: $nodename: const: "smd-edge" + apr: + $ref: /schemas/soc/qcom/qcom,apr.yaml# + description: + Qualcomm APR/GPR (Asynchronous/Generic Packet Router) + + fastrpc: + $ref: /schemas/misc/qcom,fastrpc.yaml# + description: + Qualcomm FastRPC + interrupts: maxItems: 1
Similar to qcom,glink-edge.yaml the smd-edge can also contain apr/fastrpc nodes for functionality exposed by the modem or audio DSP. These nodes are already used in existing device trees, adding them fixes the following dtbs_check warnings after converting qcom,msm8916-mss-pil to DT schema: arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: smd-edge: Unevaluated properties are not allowed ('fastrpc' was unexpected) From schema: remoteproc/qcom,msm8916-mss-pil.yaml Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> --- Since qcom,fastrpc.yaml only exists in Rob's tree right now and a similar change for qcom,glink-edge.yaml was applied there it is probably easiest if this patch goes through Rob's tree as well. --- .../devicetree/bindings/remoteproc/qcom,smd-edge.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)