diff mbox series

[-next,2/2] crypto: x86: kmsan: disable accelerated configs in KMSAN builds

Message ID 20220909095811.2166073-2-glider@google.com
State New
Headers show
Series [-next,1/2] x86: crypto: kmsan: revert !KMSAN dependencies | expand

Commit Message

Alexander Potapenko Sept. 9, 2022, 9:58 a.m. UTC
KMSAN is unable to understand when initialized values come from assembly.
Disable accelerated configs in KMSAN builds to prevent false positive
reports.

Signed-off-by: Alexander Potapenko <glider@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Eric Biggers <ebiggers@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Robert Elliott <elliott@hpe.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-next@vger.kernel.org
---
 crypto/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Alexander Potapenko Sept. 16, 2022, 9:23 a.m. UTC | #1
Hi Stephen,

Please use this patch to replace "crypto: x86: kmsan: disable
accelerated configs in KMSAN builds" when merging linux-mm into
linux-next (assuming arch/x86/crypto/Kconfig is still in -next).

On Fri, Sep 9, 2022 at 11:58 AM Alexander Potapenko <glider@google.com> wrote:
>
> KMSAN is unable to understand when initialized values come from assembly.
> Disable accelerated configs in KMSAN builds to prevent false positive
> reports.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Robert Elliott <elliott@hpe.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-next@vger.kernel.org
> ---
>  crypto/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 40423a14f86f5..4a2915bd40d1f 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1430,7 +1430,9 @@ endif
>  if SPARC
>  source "arch/sparc/crypto/Kconfig"
>  endif
> -if X86
> +# KMSAN is unable to understand when initialized values come from assembly.
> +# Disable accelerated configs to prevent false positive reports.
> +if X86 && !KMSAN
>  source "arch/x86/crypto/Kconfig"
>  endif
>
> --
> 2.37.2.789.g6183377224-goog
>
Stephen Rothwell Sept. 18, 2022, 9:45 p.m. UTC | #2
Hi Alexander,

On Fri, 16 Sep 2022 11:23:47 +0200 Alexander Potapenko <glider@google.com> wrote:
>
> Please use this patch to replace "crypto: x86: kmsan: disable
> accelerated configs in KMSAN builds" when merging linux-mm into
> linux-next (assuming arch/x86/crypto/Kconfig is still in -next).

OK, will do from today.
diff mbox series

Patch

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 40423a14f86f5..4a2915bd40d1f 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1430,7 +1430,9 @@  endif
 if SPARC
 source "arch/sparc/crypto/Kconfig"
 endif
-if X86
+# KMSAN is unable to understand when initialized values come from assembly.
+# Disable accelerated configs to prevent false positive reports.
+if X86 && !KMSAN
 source "arch/x86/crypto/Kconfig"
 endif