| Message ID | 20220913023003.1677467-1-jiasheng@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | soc: qcom: apr: Add check for idr_alloc | expand |
diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index b4046f393575..1b73ce9b4f9a 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -454,8 +454,12 @@ static int apr_add_device(struct device *dev, struct device_node *np, adev->dev.driver = NULL; spin_lock(&apr->svcs_lock); - idr_alloc(&apr->svcs_idr, svc, svc_id, svc_id + 1, GFP_ATOMIC); + ret = idr_alloc(&apr->svcs_idr, svc, svc_id, svc_id + 1, GFP_ATOMIC); spin_unlock(&apr->svcs_lock); + if (ret < 0) { + kfree(adev); + return ret; + } of_property_read_string_index(np, "qcom,protection-domain", 1, &adev->service_path);
As idr_alloc() can return negative numbers, it should be better to check the return value and deal with the exception. Fixes: 6adba21eb434 ("soc: qcom: Add APR bus driver") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/soc/qcom/apr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)