| Message ID | 20220915141601.18435-1-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | 8703d55bd5eac642275fe91b34ac62ad0ad312b5 |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size | expand |
On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote: > The size of the UFS PHY serdes register region is 0x1c8 and the > corresponding 'reg' property should specifically not include the > adjacent regions that are defined in the child node (e.g. tx and rx). > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> This fixes an issue that I'm seeing on the QDrive3 in next-20220930. Reviewed-by: Brian Masney <bmasney@redhat.com>
On Mon, Oct 03, 2022 at 01:46:29PM -0400, Brian Masney wrote: > On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote: > > The size of the UFS PHY serdes register region is 0x1c8 and the > > corresponding 'reg' property should specifically not include the > > adjacent regions that are defined in the child node (e.g. tx and rx). > > > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > This fixes an issue that I'm seeing on the QDrive3 in next-20220930. > > Reviewed-by: Brian Masney <bmasney@redhat.com> > Tested-by: Andrew Halaney <ahalaney@redhat.com> #Qdrive3/sa8540p-adp-ride
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 4b85c9276435..638317f78ab2 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1432,7 +1432,7 @@ ufs_mem_hc: ufs@1d84000 { ufs_mem_phy: phy@1d87000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; - reg = <0 0x01d87000 0 0xe10>; + reg = <0 0x01d87000 0 0x1c8>; #address-cells = <2>; #size-cells = <2>; ranges; @@ -1500,7 +1500,7 @@ ufs_card_hc: ufs@1da4000 { ufs_card_phy: phy@1da7000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; - reg = <0 0x01da7000 0 0xe10>; + reg = <0 0x01da7000 0 0x1c8>; #address-cells = <2>; #size-cells = <2>; ranges;
The size of the UFS PHY serdes register region is 0x1c8 and the corresponding 'reg' property should specifically not include the adjacent regions that are defined in the child node (e.g. tx and rx). Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)