| Message ID | 20220915203638.42917-3-gerhard@engleder-embedded.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tsnep: multi queue support and some other improvements | expand |
On Thu, 15 Sep 2022 22:36:32 +0200 Gerhard Engleder wrote: > Additional TX/RX queue pairs require dedicated interrupts. Extend > binding with additional interrupts. > > Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> In the next version please also CC krzysztof.kozlowski+dt@linaro.org
On 15/09/2022 22:36, Gerhard Engleder wrote: > Additional TX/RX queue pairs require dedicated interrupts. Extend > binding with additional interrupts. > > Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> Use scripts/get_maintainers.pl to CC all maintainers and relevant mailing lists. Best regards, Krzysztof
On 23.09.22 13:32, Krzysztof Kozlowski wrote: > On 15/09/2022 22:36, Gerhard Engleder wrote: >> Additional TX/RX queue pairs require dedicated interrupts. Extend >> binding with additional interrupts. >> >> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> > > Use scripts/get_maintainers.pl to CC all maintainers and relevant > mailing lists. Sorry I missed that. Will be done the next time.
diff --git a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml index 37e08ee744a8..ce1f1bd413c2 100644 --- a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml +++ b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml @@ -20,7 +20,23 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 8 + + interrupt-names: + minItems: 1 + maxItems: 8 + items: + pattern: '^mac|txrx-[1-7]$' + description: + If more than one interrupt is available, then interrupts are + identified by their names. + "mac" is the main interrupt for basic MAC features and the first + TX/RX queue pair. If only a single interrupt is available, then + it is assumed that this interrupt is the "mac" interrupt. + "txrx-[1-7]" are the interrupts for additional TX/RX queue pairs. + These interrupt names shall start with index 1 and increment the + index by 1 with every further TX/RX queue pair. dma-coherent: true @@ -78,4 +94,23 @@ examples: }; }; }; + tnsep1: ethernet@a0010000 { + compatible = "engleder,tsnep"; + reg = <0x0 0xa0010000 0x0 0x10000>; + interrupts = <0 93 1>, <0 94 1>, <0 95 1>, <0 96 1>; + interrupt-names = "mac", "txrx-1", "txrx-2", "txrx-3"; + interrupt-parent = <&gic>; + local-mac-address = [00 00 00 00 00 00]; + phy-mode = "rgmii"; + phy-handle = <&phy1>; + mdio { + #address-cells = <1>; + #size-cells = <0>; + suppress-preamble; + phy1: ethernet-phy@1 { + reg = <1>; + rxc-skew-ps = <1080>; + }; + }; + }; };
Additional TX/RX queue pairs require dedicated interrupts. Extend binding with additional interrupts. Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> --- .../bindings/net/engleder,tsnep.yaml | 37 ++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-)