| Message ID | 20220916205450.86278-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 56e380cfcd82a228dc006902b88cf1adaf9851dc |
| Headers | show |
| Series | [v1,1/3] pinctrl: cy8c95x0: Lock register accesses in cy8c95x0_set_mux() | expand |
On Fri, Sep 16, 2022 at 10:54 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > It seems that cy8c95x0_set_mux() missed serialization of IO access. > And its implementation looks half-baked. Add locking to the function. > > Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> All three patches are straight-forward and elegant so I just applied them. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c index 79f73d364f3f..75be06d29dc1 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1152,8 +1152,13 @@ static int cy8c95x0_set_mux(struct pinctrl_dev *pctldev, unsigned int selector, unsigned int group) { struct cy8c95x0_pinctrl *chip = pinctrl_dev_get_drvdata(pctldev); + int ret; - return cy8c95x0_pinmux_cfg(chip, selector, group); + mutex_lock(&chip->i2c_lock); + ret = cy8c95x0_pinmux_cfg(chip, selector, group); + mutex_unlock(&chip->i2c_lock); + + return ret; } static const struct pinmux_ops cy8c95x0_pmxops = {
It seems that cy8c95x0_set_mux() missed serialization of IO access. And its implementation looks half-baked. Add locking to the function. Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/pinctrl-cy8c95x0.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)