| Message ID | 20220917122015.1893880-1-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Commit | 790cf9e3da3f16d65d389d714f6e18f27cf18704 |
| Headers | show |
| Series | [-next] pinctrl: stm32: Switch to use dev_err_probe() helper | expand |
On Sat, Sep 17, 2022 at 2:13 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > In the probe path, dev_err() can be replace with dev_err_probe() > which will check if error code is -EPROBE_DEFER and prints the > error name. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Patch applied as obviously correct. Thanks! Yours, Linus Walleij
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 14bcca73238a..e485506ea599 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -1603,10 +1603,9 @@ int stm32_pctl_probe(struct platform_device *pdev) bank->clk = of_clk_get_by_name(np, NULL); if (IS_ERR(bank->clk)) { - if (PTR_ERR(bank->clk) != -EPROBE_DEFER) - dev_err(dev, "failed to get clk (%ld)\n", PTR_ERR(bank->clk)); fwnode_handle_put(child); - return PTR_ERR(bank->clk); + return dev_err_probe(dev, PTR_ERR(bank->clk), + "failed to get clk\n"); } i++; }
In the probe path, dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)