| Message ID | 20220920193936.8709-1-markpearson@lenovo.com |
|---|---|
| State | Accepted |
| Commit | 2fd003ee8ade6b7f2777becc6f9917d7c313784f |
| Headers | show |
| Series | Input: Disable Intertouch for Lenovo T14 and P14s AMD G1 | expand |
On Tue, Sep 20, 2022 at 03:39:36PM -0400, Mark Pearson wrote: > Since intertouch was enabled for the T14 and P14s AMD G1 laptops there > have been a number of reports of touchpads not working well. > > Debugging this with Synaptics they noted that intertouch should not be > enabled as SMBUS host notify is not available on these laptops. > > Reverting the previous commit (e4ce4d3a939d97bea045eafa13ad1195695f91ce) > to restore functionality back to what it was. > > Note - we are working with Synaptics to see if there is a better > solution, but nothing is confirmed as yet. > > Signed-off-by: Mark Pearson <markpearson@lenovo.com> Applied, thank you.
Resending as I hadn't seen any reviews. I think this didn't make it on the list as I can't see it on the archives :( Please let me know if there are any concerns. Thanks Mark On 2022-09-20 15:39, Mark Pearson wrote: > Since intertouch was enabled for the T14 and P14s AMD G1 laptops there > have been a number of reports of touchpads not working well. > > Debugging this with Synaptics they noted that intertouch should not be > enabled as SMBUS host notify is not available on these laptops. > > Reverting the previous commit (e4ce4d3a939d97bea045eafa13ad1195695f91ce) > to restore functionality back to what it was. > > Note - we are working with Synaptics to see if there is a better > solution, but nothing is confirmed as yet. > > Signed-off-by: Mark Pearson <markpearson@lenovo.com> > --- > drivers/input/mouse/synaptics.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 434d48ae4b12..ffad142801b3 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -186,7 +186,6 @@ static const char * const smbus_pnp_ids[] = { > "LEN2044", /* L470 */ > "LEN2054", /* E480 */ > "LEN2055", /* E580 */ > - "LEN2064", /* T14 Gen 1 AMD / P14s Gen 1 AMD */ > "LEN2068", /* T14 Gen 1 */ > "SYN3052", /* HP EliteBook 840 G4 */ > "SYN3221", /* HP 15-ay000 */
Hi Mark, On Fri, Oct 14, 2022 at 03:24:07PM -0400, Mark Pearson wrote: > Resending as I hadn't seen any reviews. I think this didn't make it on > the list as I can't see it on the archives :( I believe this is commit 2fd003ee8ade6b7f2777becc6f9917d7c313784f and it should be part of 6.0 release. Thanks.
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 434d48ae4b12..ffad142801b3 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -186,7 +186,6 @@ static const char * const smbus_pnp_ids[] = { "LEN2044", /* L470 */ "LEN2054", /* E480 */ "LEN2055", /* E580 */ - "LEN2064", /* T14 Gen 1 AMD / P14s Gen 1 AMD */ "LEN2068", /* T14 Gen 1 */ "SYN3052", /* HP EliteBook 840 G4 */ "SYN3221", /* HP 15-ay000 */
Since intertouch was enabled for the T14 and P14s AMD G1 laptops there have been a number of reports of touchpads not working well. Debugging this with Synaptics they noted that intertouch should not be enabled as SMBUS host notify is not available on these laptops. Reverting the previous commit (e4ce4d3a939d97bea045eafa13ad1195695f91ce) to restore functionality back to what it was. Note - we are working with Synaptics to see if there is a better solution, but nothing is confirmed as yet. Signed-off-by: Mark Pearson <markpearson@lenovo.com> --- drivers/input/mouse/synaptics.c | 1 - 1 file changed, 1 deletion(-)