diff mbox

arm64: mm: dump: Use VA_START directly instead of private LOWEST_ADDR

Message ID 1454140521-741-1-git-send-email-wangkefeng.wang@huawei.com
State Accepted
Commit cc30e6b95c9a6d29f7d2083c9f64e8dec642a99e
Headers show

Commit Message

Kefeng Wang Jan. 30, 2016, 7:55 a.m. UTC
Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR
definition in dump.c.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

---
 arch/arm64/mm/dump.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.6.0.GIT


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Comments

Mark Rutland Feb. 1, 2016, 10:23 a.m. UTC | #1
On Sat, Jan 30, 2016 at 03:55:21PM +0800, Kefeng Wang wrote:
> Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR

> definition in dump.c.

> 

> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>


FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>


Mark.

> ---

>  arch/arm64/mm/dump.c | 4 +---

>  1 file changed, 1 insertion(+), 3 deletions(-)

> 

> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c

> index 0adbebb..b3c62b1 100644

> --- a/arch/arm64/mm/dump.c

> +++ b/arch/arm64/mm/dump.c

> @@ -27,8 +27,6 @@

>  #include <asm/pgtable.h>

>  #include <asm/pgtable-hwdef.h>

>  

> -#define LOWEST_ADDR	(UL(0xffffffffffffffff) << VA_BITS)

> -

>  struct addr_marker {

>  	unsigned long start_address;

>  	const char *name;

> @@ -316,7 +314,7 @@ static int ptdump_show(struct seq_file *m, void *v)

>  		.marker = address_markers,

>  	};

>  

> -	walk_pgd(&st, &init_mm, LOWEST_ADDR);

> +	walk_pgd(&st, &init_mm, VA_START);

>  

>  	note_page(&st, 0, 0, 0);

>  	return 0;

> -- 

> 2.6.0.GIT

> 

> 

> _______________________________________________

> linux-arm-kernel mailing list

> linux-arm-kernel@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Kefeng Wang Feb. 14, 2016, 8:57 a.m. UTC | #2
Hi Catalin and Will,  ping...

On 2016/2/1 18:23, Mark Rutland wrote:
> On Sat, Jan 30, 2016 at 03:55:21PM +0800, Kefeng Wang wrote:

>> Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR

>> definition in dump.c.

>>

>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

> 

> FWIW:

> 

> Acked-by: Mark Rutland <mark.rutland@arm.com>

> 

> Mark.

> 

>> ---

>>  arch/arm64/mm/dump.c | 4 +---

>>  1 file changed, 1 insertion(+), 3 deletions(-)

>>

>> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c

>> index 0adbebb..b3c62b1 100644

>> --- a/arch/arm64/mm/dump.c

>> +++ b/arch/arm64/mm/dump.c

>> @@ -27,8 +27,6 @@

>>  #include <asm/pgtable.h>

>>  #include <asm/pgtable-hwdef.h>

>>  

>> -#define LOWEST_ADDR	(UL(0xffffffffffffffff) << VA_BITS)

>> -

>>  struct addr_marker {

>>  	unsigned long start_address;

>>  	const char *name;

>> @@ -316,7 +314,7 @@ static int ptdump_show(struct seq_file *m, void *v)

>>  		.marker = address_markers,

>>  	};

>>  

>> -	walk_pgd(&st, &init_mm, LOWEST_ADDR);

>> +	walk_pgd(&st, &init_mm, VA_START);

>>  

>>  	note_page(&st, 0, 0, 0);

>>  	return 0;

>> -- 

>> 2.6.0.GIT

>>

>>

>> _______________________________________________

>> linux-arm-kernel mailing list

>> linux-arm-kernel@lists.infradead.org

>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

>>

> 

> .

> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Catalin Marinas Feb. 15, 2016, 10:09 a.m. UTC | #3
On Sun, Feb 14, 2016 at 04:57:18PM +0800, Kefeng Wang wrote:
> On 2016/2/1 18:23, Mark Rutland wrote:

> > On Sat, Jan 30, 2016 at 03:55:21PM +0800, Kefeng Wang wrote:

> >> Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR

> >> definition in dump.c.

> >>

> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>


I'll merge this patch for 4.6 but we currently have some issues with the
arm64 for-next/core branch, so I'm not pushing any more patches out
until we figure out what's going on (or I may just start with a clean
branch again, removing some big changes in there).

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index 0adbebb..b3c62b1 100644
--- a/arch/arm64/mm/dump.c
+++ b/arch/arm64/mm/dump.c
@@ -27,8 +27,6 @@ 
 #include <asm/pgtable.h>
 #include <asm/pgtable-hwdef.h>
 
-#define LOWEST_ADDR	(UL(0xffffffffffffffff) << VA_BITS)
-
 struct addr_marker {
 	unsigned long start_address;
 	const char *name;
@@ -316,7 +314,7 @@  static int ptdump_show(struct seq_file *m, void *v)
 		.marker = address_markers,
 	};
 
-	walk_pgd(&st, &init_mm, LOWEST_ADDR);
+	walk_pgd(&st, &init_mm, VA_START);
 
 	note_page(&st, 0, 0, 0);
 	return 0;