| Message ID | 20220922195651.345369-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pinctrl/arm64: qcom: continued - fix Qualcomm LPASS pinctrl schema warnings | expand |
On Thu, Sep 22, 2022 at 09:56:40PM +0200, Krzysztof Kozlowski wrote: > Fix double ']' in GPIO pattern to properly match "pins" property. > Otherwise schema for pins state is not applied. Huh? The schema is applied, but would fail, right? Perhaps the example should have some child nodes to demonstrate this. > > Fixes: 958bb025f5b3 ("dt-bindings: pinctrl: qcom: Add sc8280xp lpass lpi pinctrl bindings") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > index 1f468303bb08..fb3ad6c0d80e 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > @@ -58,7 +58,7 @@ patternProperties: > List of gpio pins affected by the properties specified in this > subnode. > items: > - pattern: "^gpio([0-1]|1[0-8]])$" > + pattern: "^gpio([0-1]|1[0-8])$" > > function: > enum: [ swr_tx_clk, swr_tx_data, swr_rx_clk, swr_rx_data, > -- > 2.34.1 > >
On Mon, Sep 26, 2022 at 3:33 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Sep 22, 2022 at 09:56:40PM +0200, Krzysztof Kozlowski wrote: > > Fix double ']' in GPIO pattern to properly match "pins" property. > > Otherwise schema for pins state is not applied. > > Huh? The schema is applied, but would fail, right? > > Perhaps the example should have some child nodes to demonstrate this. NM, I see you've done that in subsequent patches. So other than the confusing commit msg: Acked-by: Rob Herring <robh@kernel.org>
On 26/09/2022 22:40, Rob Herring wrote: > On Mon, Sep 26, 2022 at 3:33 PM Rob Herring <robh@kernel.org> wrote: >> >> On Thu, Sep 22, 2022 at 09:56:40PM +0200, Krzysztof Kozlowski wrote: >>> Fix double ']' in GPIO pattern to properly match "pins" property. >>> Otherwise schema for pins state is not applied. >> >> Huh? The schema is applied, but would fail, right? >> >> Perhaps the example should have some child nodes to demonstrate this. > > NM, I see you've done that in subsequent patches. So other than the > confusing commit msg: > > Acked-by: Rob Herring <robh@kernel.org> Yes, I'll adjust the commit msg. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml index 1f468303bb08..fb3ad6c0d80e 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml @@ -58,7 +58,7 @@ patternProperties: List of gpio pins affected by the properties specified in this subnode. items: - pattern: "^gpio([0-1]|1[0-8]])$" + pattern: "^gpio([0-1]|1[0-8])$" function: enum: [ swr_tx_clk, swr_tx_data, swr_rx_clk, swr_rx_data,
Fix double ']' in GPIO pattern to properly match "pins" property. Otherwise schema for pins state is not applied. Fixes: 958bb025f5b3 ("dt-bindings: pinctrl: qcom: Add sc8280xp lpass lpi pinctrl bindings") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)