diff mbox series

Input: melfas_mip4 - fix return value check in mip4_probe()

Message ID 20220924030715.1653538-1-yangyingliang@huawei.com
State Accepted
Commit a54dc27bd25f20ee3ea2009584b3166d25178243
Headers show
Series Input: melfas_mip4 - fix return value check in mip4_probe() | expand

Commit Message

Yang Yingliang Sept. 24, 2022, 3:07 a.m. UTC
devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER),
add a minus sign to fix it.

Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/input/touchscreen/melfas_mip4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Sept. 25, 2022, 5:10 a.m. UTC | #1
On Sat, Sep 24, 2022 at 11:07:15AM +0800, Yang Yingliang wrote:
> devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER),
> add a minus sign to fix it.
> 
> Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index 2745bf1aee38..83f4be05e27b 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -1453,7 +1453,7 @@  static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id)
 					      "ce", GPIOD_OUT_LOW);
 	if (IS_ERR(ts->gpio_ce)) {
 		error = PTR_ERR(ts->gpio_ce);
-		if (error != EPROBE_DEFER)
+		if (error != -EPROBE_DEFER)
 			dev_err(&client->dev,
 				"Failed to get gpio: %d\n", error);
 		return error;