diff mbox series

[1/5] Input: lm8333 - add missing linux/input.h include

Message ID 20220923194738.927408-1-dmitry.torokhov@gmail.com
State Accepted
Commit ddc9589d7921d7af4cc8fa6e0477d83fd95adef5
Headers show
Series [1/5] Input: lm8333 - add missing linux/input.h include | expand

Commit Message

Dmitry Torokhov Sept. 23, 2022, 7:47 p.m. UTC
We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.

Also let's sort includes alphabetically and drop unneeded irq.h

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/keyboard/lm8333.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Andy Shevchenko Sept. 26, 2022, 10:57 a.m. UTC | #1
On Fri, Sep 23, 2022 at 12:47:34PM -0700, Dmitry Torokhov wrote:
> We are going to clean up matrix_keymap.h from unnecessary includes,
> so the driver needs to include API that it uses directly.
> 
> Also let's sort includes alphabetically and drop unneeded irq.h

For the entire series:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for doing this!
diff mbox series

Patch

diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
index 9dac22c14125..3052cd6dedac 100644
--- a/drivers/input/keyboard/lm8333.c
+++ b/drivers/input/keyboard/lm8333.c
@@ -4,13 +4,13 @@ 
  * Copyright (C) 2012 Wolfram Sang, Pengutronix <kernel@pengutronix.de>
  */
 
-#include <linux/module.h>
-#include <linux/slab.h>
-#include <linux/irq.h>
 #include <linux/i2c.h>
-#include <linux/interrupt.h>
+#include <linux/input.h>
 #include <linux/input/matrix_keypad.h>
 #include <linux/input/lm8333.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/slab.h>
 
 #define LM8333_FIFO_READ		0x20
 #define LM8333_DEBOUNCE			0x22