| Message ID | 20220925110608.145728-12-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pinctrl/arm64: qcom: 4th set of Qualcomm TLMM pinctrl schema warnings | expand |
On 25.09.2022 13:06, Krzysztof Kozlowski wrote: > Document common GPIO properties (gpio-reserved-ranges and > gpio-line-names), already used on qrb5165-rb5 board. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > index c44d02d28bc9..d7d8e5d3b659 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > @@ -49,6 +49,13 @@ properties: > gpio-ranges: > maxItems: 1 > > + gpio-reserved-ranges: > + minItems: 1 Not sure about this.. However, this will apply to 99.9% of boards, so: Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > + maxItems: 90 > + > + gpio-line-names: > + maxItems: 180 > + > wakeup-parent: true > > #PIN CONFIGURATION NODES
On 27/09/2022 14:41, Konrad Dybcio wrote: > > > On 25.09.2022 13:06, Krzysztof Kozlowski wrote: >> Document common GPIO properties (gpio-reserved-ranges and >> gpio-line-names), already used on qrb5165-rb5 board. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml >> index c44d02d28bc9..d7d8e5d3b659 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml >> @@ -49,6 +49,13 @@ properties: >> gpio-ranges: >> maxItems: 1 >> >> + gpio-reserved-ranges: >> + minItems: 1 > Not sure about this.. However, this will apply to 99.9% of boards, so: We need some minimum number. Best regards, Krzysztof
On Sun, 25 Sep 2022 13:06:04 +0200, Krzysztof Kozlowski wrote: > Document common GPIO properties (gpio-reserved-ranges and > gpio-line-names), already used on qrb5165-rb5 board. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index c44d02d28bc9..d7d8e5d3b659 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -49,6 +49,13 @@ properties: gpio-ranges: maxItems: 1 + gpio-reserved-ranges: + minItems: 1 + maxItems: 90 + + gpio-line-names: + maxItems: 180 + wakeup-parent: true #PIN CONFIGURATION NODES
Document common GPIO properties (gpio-reserved-ranges and gpio-line-names), already used on qrb5165-rb5 board. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++ 1 file changed, 7 insertions(+)