| Message ID | 20220927113426.49724-2-povik+lin@cutebit.org |
|---|---|
| State | Accepted |
| Commit | e92e50e4263f5cf9c731ef5593c31f94dc3b7b8c |
| Headers | show |
| Series | [1/3] ASoC: apple: mca: Trigger, not deassert, the peripheral reset | expand |
diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c index 75925bfcf754..7ca653987b78 100644 --- a/sound/soc/apple/mca.c +++ b/sound/soc/apple/mca.c @@ -970,18 +970,11 @@ static const struct snd_soc_component_driver mca_component = { static void apple_mca_release(struct mca_data *mca) { - int i, stream; + int i; for (i = 0; i < mca->nclusters; i++) { struct mca_cluster *cl = &mca->clusters[i]; - for_each_pcm_streams(stream) { - if (IS_ERR_OR_NULL(cl->dma_chans[stream])) - continue; - - dma_release_channel(cl->dma_chans[stream]); - } - if (!IS_ERR_OR_NULL(cl->clk_parent)) clk_put(cl->clk_parent);
The commit 4ec8179c212f ("ASoC: apple: mca: Postpone requesting of DMA channels") shuffled around with the requesting and releasing of DMA channels. It left behind stale release calls from within apple_mca_release, remove those now. Fixes: 4ec8179c212f ("ASoC: apple: mca: Postpone requesting of DMA channels") Signed-off-by: Martin Povišer <povik+lin@cutebit.org> --- sound/soc/apple/mca.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)